Commit Graph

1002 Commits

Author SHA1 Message Date
Paddy
adc206a02d Add test case for updating to remove member.
Add a test case that updates a binding to remove a member.
2017-07-27 13:50:06 -07:00
Paddy
199ff5d1f1 Excise unnecessary type declarations.
Some struct types can be inferred instead of being repeated, so let's
take advantage of that.
2017-07-27 13:39:23 -07:00
Paddy
fa2d54f408 Terraform fmt website examples. 2017-07-25 12:22:52 -07:00
Paddy
655435f940 Terraform fmt on our test configs. 2017-07-25 12:17:20 -07:00
Paddy
91d227cdb0 id => project_id
For clarity and explicitness(? is that a word?) use the project_id
instead of Terraform's internal id in our test configs.
2017-07-25 12:15:28 -07:00
Paddy
b0e3790b61 Use the policy r/m/w helper and handle edge case.
Use the new projectIamPolicyReadModifyWrite helper to manage the RMW
loop for our policy member resource.

Handle the case of having a binding server-side that doesn't have the
member we expect more elegantly.
2017-07-25 12:14:05 -07:00
Paddy
52d552d740 id => project_id in test configs.
Helps keep things explicit.
2017-07-25 12:00:03 -07:00
Paddy
f9eeb36657 terraform fmt test configs. 2017-07-25 11:56:27 -07:00
Paddy
5282ad7b12 Use string slice conversion helper. 2017-07-25 11:52:38 -07:00
Paddy
729e9fc501 Create an iam policy read/modify/write helper.
We were repeating that logic a lot, so this helper just reads a policy,
calls the passed modify function on the policy, then writes the policy
back and takes care of the optimistic concurrency logic for the caller.
So now all the caller has to do is the unique part, which is the modify
function.
2017-07-25 11:43:49 -07:00
Paddy
9c1c0bbc52 Just remove deleted bindings not present in the API.
We can just set the ID of bindings that are scheduled to be deleted but
don't exist in the API, we don't need an entire separate read request.
2017-07-25 11:12:15 -07:00
Paddy
d3f901bfc3 Refactor binding update loop for clarity.
Rewrite the structure of our if statement to make the conditions under
which each portion executes a bit more clear.
2017-07-25 11:08:34 -07:00
Paddy
8a880fdcf8 Documentation updates.
Fix a sentence in the binding docs, and add docs for members.
2017-07-03 21:05:02 -07:00
Paddy
f9236abdf8 Add the google_project_iam_member resource.
Adds the google_project_iam_member resource, which just ensures that a
single member has a single role.

google_project_iam_member should not be used to grant permissions to a
role controlled by google_project_iam_binding or to a policy controlled
by google_project_iam_policy, as they'll fight for control.
2017-07-03 20:59:26 -07:00
Paddy
a84b22dda2 Fix vet errors.
Add the missing parameter to Errorf statements.
2017-07-03 20:53:32 -07:00
Paddy
65a4a36362 Remove ID when binding isn't found.
It shouldn't be an error, we should just remove that binding from state.
2017-07-03 20:50:25 -07:00
Paddy
11abe2447c Fix reads, make ForceNew.
Changing the role is ForceNew, because the role is part of the ID.

Make reads go through to the Binding functions, not the Policy
functions. That's embarrassing.
2017-07-03 19:36:55 -07:00
Paddy
eed8487971 Update website docs for google_project_iam_binding.
Add docs to the website for google_project_iam_binding.
2017-07-03 19:12:24 -07:00
Paddy
8e704876bc Add google_project_iam_binding resource.
Add a resource that manages just a single binding within a Google
project's IAM Policy.

Note that this resource should not be used when
google_project_iam_policy is used, or they will fight over which is
correct.

This also required wrapping the error returned from setProjectIamPolicy,
as we need to test to see if it's a 409 error and retry, which can't be
done if we just use fmt.Errorf.
2017-07-03 19:01:08 -07:00
Jake Champlin
c48ef17ed7 Merge pull request #169 from nicolai86/master
docs: add undocumented attributes
2017-06-30 11:31:12 -04:00
Raphael Randschau
4c2fbfcd27
chore(docs): add undocumented attributes 2017-06-30 12:36:47 +02:00
Raphael Randschau
e8af028fb5
chore(docs): remove trailing . 2017-06-30 12:36:47 +02:00
stack72
9ce542e1fb Adding back the GNUmakefile test-compile step 2017-06-30 11:16:10 +03:00
Joe Selman
9691fe13ea Merge pull request #166 from selmanj/update-changelog
Update CHANGELOG.md
2017-06-29 13:10:02 -07:00
stack72
fc1507fe52 Simplifying the GNUMakefile 2017-06-29 16:43:40 +03:00
Joe Selman
9fe21163d3 Update CHANGELOG.md 2017-06-28 16:18:08 -07:00
Dana Hoffman
029762344c Update CHANGELOG.md 2017-06-28 15:46:17 -07:00
Dana Hoffman
32bf0df2d0 Add scratch_disk property to google_compute_instance and deprecate disk (#123)
* Add scratch_disk property to google_compute_instance

* docs for scratch_disk

* limit scope of scratchDisks array by using bool, test formatting

* add slash back to disk check
2017-06-28 15:43:58 -07:00
Dana Hoffman
549e1314f9 Add boot_disk property to google_compute_instance (#122)
* Add boot_disk property to google_compute_instance

* docs for boot_disk

* limit scope of bootDisk, use bool instead

* test formatting

* make device_name forcenew, add sha256 encryption key
2017-06-28 15:36:00 -07:00
Dana Hoffman
2f17ba7596 Merge pull request #160 from danawillow/googleapi
revendor googleapi
2017-06-28 14:34:46 -07:00
Joe Selman
1137ee7023 Merge pull request #150 from selmanj/add_labels_to_compute_instance
Add support for using labels on compute_instance
2017-06-28 09:44:32 -07:00
Dana Hoffman
75e4af923e revendor googleapi/internal/uritemplates 2017-06-28 09:24:00 -07:00
Paul Stack
ad6765f320 Update CHANGELOG.md 2017-06-28 11:44:03 +03:00
stack72
8798346e70 Add an acceptance test to show timeouts in container_cluster 2017-06-28 11:34:20 +03:00
sovanesyan
b2f789ca0a provider/google: Add Timeout support to google_container_cluster
Migrated from https://github.com/hashicorp/terraform/pull/13203
2017-06-28 11:24:28 +03:00
Dana Hoffman
b19ae9ca8f revendor googleapi 2017-06-27 17:43:43 -07:00
Riley Karson
3c7cdf0bb4 Updated import documentation. (#156) 2017-06-27 17:07:47 +03:00
Dana Hoffman
e2f05cba90 Update CHANGELOG.md 2017-06-26 13:18:56 -07:00
Jake Champlin
5c86ea25ef
Update Changelog for google provider 2017-06-26 15:11:47 -04:00
Joe Selman
e3c27065dc Add support for using labels on compute_instance 2017-06-26 10:37:16 -07:00
Paul Stack
385bbc8add Update CHANGELOG.md 2017-06-26 18:26:18 +03:00
Riley Karson
e5267f2c6f Fix read method + test/document import for google_compute_health_check (#155)
* Read health check block + add import support to google_compute_health_check.

* Updated google_compute_health_check documentation.
2017-06-26 18:25:22 +03:00
Jake Champlin
234a95e0b8
Fix Changelog Links Script for google provider 2017-06-26 09:50:55 -05:00
Joe Selman
ea2baec904 Merge pull request #146 from selmanj/readme_changes
Minor Readme changes
2017-06-23 13:37:37 -07:00
Dana Hoffman
1c20afeef3 Merge pull request #153 from terraform-providers/danawillow-changelog-categories
Categorize changelog by the API used
2017-06-22 14:24:55 -07:00
Paddy
e72b6fd217 Update CHANGELOG.md 2017-06-22 13:57:51 -07:00
Paddy
89431e9a2a Merge pull request #147 from pmcatominey/firewall-source
compute_firewall: set source_ranges to Computed to avoid perpetual diff
2017-06-22 13:29:20 -07:00
Riley Karson
aa5449ab34 Update CHANGELOG.md 2017-06-22 10:30:13 -07:00
Mike Fowler
58a6b3f80e Add import for google_sql_database_instance (#11)
* Add import for `google_sql_database_instance`

* Alterations suggested by review

* Move declaration of array for clarification
2017-06-22 10:25:26 -07:00
Joe Selman
13025b2f11 Fix broken link 2017-06-22 10:12:07 -07:00