Commit Graph

151 Commits

Author SHA1 Message Date
Nicki Watt
752b406783 Add Google Spanner Support (google_spanner_database) (#271) 2017-08-14 09:53:11 -07:00
Vincent Roseberry
31afabb864 Rename spanner instance import tests to match format of resource tests (#324) 2017-08-14 09:47:02 -07:00
Nicki Watt
04b3ffb8ea Add Google Spanner Support (google_spanner_instance) (#270) 2017-08-14 09:30:41 -07:00
Vincent Roseberry
9c159c6a96 Change required fields to computed in compute instance group datasource (#323) 2017-08-11 15:49:45 -07:00
Riley Karson
5645f72996 Add support for instance_type to google_bigtable_instance. (#313)
* govendor fetch cloud.google.com/go/bigtable

* Vendor the rest of the stuff.

* Add support for instance_type to google_bigtable_instance.

* Revendored some packages.

* Removed bad packages from vendor.json
2017-08-11 14:43:00 -07:00
Roberto Jung Drebes
5602218586 allow configuring node_config of node_pools specified in container_cluster (#299) 2017-08-11 12:23:17 -07:00
Joe Selman
e0e9b3a4d7 Remove default value for removed value automatic_restart (#321)
Import tests for compute_instance_template fail without this change as
they expect a value of true for automatic_restart. As this value was
removed, we're no longer setting it (and therefore it looks like it has
a value of false, which is different from the default).
2017-08-11 10:46:30 -07:00
Aleksandr Didenko
99b43ac400 Add compute instance group data source (#267) 2017-08-11 10:17:36 -07:00
Riley Karson
5c71655bac Changed zone name to be read correctly in google_compute_disk. (#320) 2017-08-10 13:41:27 -07:00
Riley Karson
ff8bdc9b52 Remove Beta operation waiting code and just wait at v1 instead. (#319) 2017-08-10 13:01:56 -07:00
Riley Karson
9e76fab11b Convert old validation functions to use IntAtLeast from helper/validation. (#312)
* Convert old validation functions to use IntAtLeast in helper/validation.

* make fmt

* Remove unused import.
2017-08-10 13:01:45 -07:00
Riley Karson
39423dd063 Stop shadowing err in version switches by using = over := (#318) 2017-08-10 10:29:18 -07:00
Vincent Roseberry
52daf4097a Add subnetwork secondary ip ranges beta feature (#310) 2017-08-09 15:02:54 -07:00
Joe Selman
f9d0570168 Fix scheduling automatic restart, remove deprecated options (#248)
* Fix bug where scheduling.automatic_restart false is never used

* Remove deprecated automatic_restart value in favor of scheduling.automatic_restart

* Remove deprecated on_host_maintenance

* Correct bad var name

* Re-add removed schema values and marked as Removed

* Fix var to snake case

* Migrate empty scheduling blocks in compute_instance_template

* Shorten error message

* Use only one return value instead of two
2017-08-09 12:25:16 -07:00
Stefan Schmidt
caeb43e39a Mark google_sql_database.{charset,collation} as computed instead of having defaults (#229)
* Mark google_sql_database.{charset,collation} as computed instead of having defaults.

This change is required to avoid the following scenario:
When upgrading from a previous version of the Google provider, TF will change
the charset/collation of existing (TF-managed) databases to utf8/utf8_general_ci
(if the user hasn't added different config values before running TF apply),
potentially overriding any non-default settings that the user my have applied
through the Cloud SQL admin API. This violates POLA.

* Remove charset/collation defaults from the documentation, too.

* Add links to MySQL's and PostgreSQL's documentation about supported charset and collation values.

* Use version 5.7's docs instead of 5.6, since that's the most up to date version of MySQL that we support.

* Add a note that only UTF8 / en_US.UTF8 are currently supported for Cloud SQL PostgreSQL databases.
2017-08-08 14:32:16 -07:00
Riley Karson
89ce4d92e4 Add Beta support for egress/direction to google_compute_firewall. (#306)
* Add Beta support for direction to google_compute_firewall.

* Added docs.
2017-08-08 13:28:49 -07:00
Joe Selman
73ef33191d Allow specifying resource name for project metadata item config in tests (#305) 2017-08-08 13:05:13 -07:00
Dana Hoffman
e9e9f835ec Allow upgrading GKE versions and provide better error message handling (#291)
* Better error handling for GKE operations

* Handle GKE version upgrades

* clarify log message
2017-08-08 11:31:12 -07:00
Riley Karson
2d0d8bdcc0 Add Beta support & Beta feature deny to google_compute_firewall (#282)
* Add versioned Beta support to google_compute_firewall.

* Add Beta support for deny to google_compute_firewall.

* remove extra line:

* make fmt

* Add missing ForceNew fields.

* Respond to review comments testing functionality + reducing network GET to v1
2017-08-07 13:14:35 -07:00
Vincent Roseberry
c9e2ce7f08 Change google_container_node_pool ID format to zone/cluster/name to remove artificial restriction on node pool name across clusters (#304) 2017-08-07 12:52:02 -07:00
Anders Bruun Olsen
f06970c97a Make google_container_node_pool resources importable. (#284) 2017-08-07 10:35:39 -07:00
Vincent Roseberry
018e01887b Fail if both name and name_prefix are set for node_pool in google_container_cluster (#296) 2017-08-04 15:34:02 -07:00
Vincent Roseberry
1480539c82 Remove ConflictsWith for network and subnetwork. More than one interface is supported and ConflictsWith doesn't support List properly (#294) 2017-08-04 14:22:04 -07:00
Riley Karson
a4e1083fd1 Add a test that multiple nics work in google_compute_instance. (#289)
* Add a test that multiple nics works in google_compute_instance.

* Add note that multiple nics is in Beta.
2017-08-04 14:18:07 -07:00
Vincent Roseberry
3fde8cf24e google_compute_instance can specified the subnetwork using a self_link (#290) 2017-08-04 11:00:45 -07:00
Riley Karson
68f2e3528c Add Beta support & Beta feature ip_version to google_compute_global_address (#250)
* Make google_compute_global_address a versioned resource with Beta support.

* Added Beta support for ip_version in google_compute_global_address.

* Move checks to TestCheckFuncs, add a regression test for IPV4 on v1 resources.

* Consolidated TestCheckFuncs to a single function.

* Add missing return statement.

* Fix IPV4 test

* Clarified comment.
2017-08-04 10:53:43 -07:00
Matt Morrison
0be42521c1 Fix error if container_node_pool deleted out of band (#293)
Prior to this change it was possible for Terraform to error during plan / apply with the following:
Error 404: The resource "node pool \"foo\" not found"
2017-08-04 10:24:53 -07:00
Riley Karson
0d02b116c7 Add Beta support & Beta feature ip_version to google_compute_global_forwarding_rule (#265)
* Add versioned Beta support to google_compute_global_forwarding_rule.

* Add Beta support for ip_version in google_compute_global_forwarding_rule.

* Temporary commit with compute_shared_operation.go changes.

* Added a test to see if v1 GFR is still IPV4, moved to a TestCheckFunc

* This API returns the original self links, but let's make sure we don't diff.
2017-08-04 10:15:51 -07:00
alex1x
8570849022 Add Support for Google source repos (#256) 2017-08-03 15:00:34 -07:00
Vincent Roseberry
ec21efb665 google_compute_instance reads scheduling fields from GCP. (#237) 2017-08-03 13:51:45 -07:00
Riley Karson
9f429e7ed2 Read from the zone set in state when possible in google_compute_autoscaler (#193) 2017-08-03 12:52:48 -07:00
Dana Hoffman
0afcb4d52c compute-component api has been replaced by compute, update tests (#276) 2017-08-03 10:58:58 -07:00
Riley Karson
3877b340e6 Add Beta support for auto_healing_policies to instance group manager. (#249)
* Add support for auto_healing_policies to google_compute_instance_group_manager.

* Add a test for self link stability when a v1 resource uses a versioned resource.

* Add a comment about what the stable self link test does.

* make fmt

* Fixed formatting on new tests.

* Address review comments.

* Fix make vet
2017-08-02 10:12:16 -07:00
Matt Morrison
0595ef25a5 Fix disk type’Malformed URL’ error (#275)
* Fix disk type’Malformed URL’ error

The API expects the disk type to be a SelfLink URL, but the disk type 
name was being used (e.g. “pd-ssd”).

* Add ACC Tests for boot disk type

* Fix acceptance test & fmt test config

The Instance data does not contain the actual disk type, just "PERSISTENT". This commit uses the computeClient to pull the disk data from the API, allowing checking of the disk type.

Also fmt'd the test configuration.
2017-08-01 15:39:32 -07:00
Dana Hoffman
947c18ec7a Persist state from the API for google_sql_database_instance regardless of what attributes the user has set (#208) 2017-08-01 13:13:09 -07:00
Joe Selman
c6ae260d63 Use a unique key when running project_metadata_item import tests (#274)
CI runs tests concurrently and will interfere with each other with the
current global key name.
2017-08-01 11:14:13 -07:00
Joe Selman
28f8931f0b Fix bug where startup-script metadata did not refresh (#180)
* Fix bug where startup-script metadata did not refresh

* Remove MetadataFormatSchema and replace with explicit filters/transforms
2017-08-01 10:47:58 -07:00
Dana Hoffman
32d7c3f62c Add support for legacyAbac to google_container_cluster (#261)
* revendor container api

* Add support for legacyAbac to `google_container_cluster`

* change to single enabled field
2017-07-31 11:09:05 -07:00
Aleksandr Didenko
1ec19cf3d9 Add support node config for GKE node pool (#184)
* Add support node config for GKE node pool

* Review fixes:
- Set max items in node config schema
- Fill missing node config fields
- Put test helpers above than test vars

* Update checks in node pool tests

* Fix node pool check match
2017-07-31 09:28:39 -07:00
Vincent Roseberry
53e481434e Add new data source: google_dns_managed_zone (#268) 2017-07-31 09:27:18 -07:00
Joe Selman
060861e678 Add an additional test with multiple project metadata items (#222)
This additional test would have caught the error fixed in
8f75c1c9a5
2017-07-28 15:50:12 -07:00
Joe Selman
88b1f092ff Fix issue with nondeterminism in tests (#226) 2017-07-28 12:59:19 -07:00
Paddy
37df58296b Merge pull request #171 from terraform-providers/paddy_iam
Add google_project_iam_binding and google_project_iam_member resources.
2017-07-28 12:22:33 -07:00
Joe Selman
50c10d4e7d Revert "Revert metadata item changes (#225)" (#257)
* Revert "Revert metadata item changes (#225)"

This reverts commit 884158d891.

* Use computeOperationWait instead of computeOperationWaitGlobal
2017-07-28 10:49:02 -07:00
Vincent Roseberry
3eaf4751db Add new resource google_compute_network_peering (#259) 2017-07-28 09:51:29 -07:00
Paddy
6f98217d66 Fix embarrassing typo in log message. 2017-07-27 14:37:39 -07:00
Paddy
d3426d5bc6 Don't set IDs in RMW loops.
We don't need to set the ID to "" in read-modify-write helpers, because
once they're done, we read anyways to update state based on the changes.
And that read checks if the binding/member still exists, and does the
SetId("") if it doesn't.

This way, we stick with state only getting set based on the API state,
not by what we think the state will be.
2017-07-27 14:29:25 -07:00
Paddy
ac5df40896 Return a type that was needed, rename a test function.
Tests need to have unique names. Whoooops.

Also, the Elem property accepts an interface I guess, which means we
actually need the struct type repetition there.
2017-07-27 14:11:52 -07:00
Paddy
f88e0429c7 Test adding multiple bindings at once. 2017-07-27 14:06:15 -07:00
Paddy
78545359bd Add logging statements, update : to / in IDs.
Update member IDs to use / instead of :.

Make sure we're logging any time we remove something from state.
2017-07-27 14:01:47 -07:00