public/terraform-provider-google
0
0
Fork 0
mirror of https://github.com/letic/terraform-provider-google.git synced 2024-07-01 07:42:40 +00:00
Code Issues Projects Releases Wiki Activity

Fix bug where range variable is improperly dereferenced (#217)

Browse Source 
* Fix bug where range variable is improperly dereferenced

* Add comment explaining why a value is copied
This commit is contained in:
Joe Selman 2017-07-19 13:19:27 -07:00 committed by GitHub
parent 6c27e076ce
commit 8f75c1c9a5
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
google/metadata.go
View File

@ -103,7 +103,10 @@ func expandComputeMetadata(m map[string]string) []*compute.MetadataItems {
idx := 0
for key, value := range m {
metadata[idx] = &compute.MetadataItems{Key: key, Value: &value}
// Make a copy of value as we need a ptr type; if we directly use 'value' then all items will reference the same
// memory address
vtmp := value
metadata[idx] = &compute.MetadataItems{Key: key, Value: &vtmp}
idx++
}