Fixes#1494.
* Add import support for `google_logging_organization_sink`, `google_logging_folder_sink`, `google_logging_billing_account_sink`.
Using `StateFunc` over `DiffSuppressFunc` should only affect tests; for some reason `TestAccLoggingFolderSink_folderAcceptsFullFolderPath` expected a `folder` value of `folders/{{id}}` vs expecting `{{id}}` when only `DiffSuppressFunc` was used, when in real use `DiffSuppressFunc` should be sufficient.
This doesn't appear to be used anywhere within this project.
Additionally Hashicorp has their own [uuid library](https://github.com/hashicorp/go-uuid)
which is used internally.
@michaelharo suggested this would be a good best practice for this particular resource to prevent users from accidentally deleting a bunch of encryption keys on a -/+ and losing data, and I agree.
This commit adds a quick documentation blurb saying what actually happens if those crypto key versions are destroyed and also updates the snippet to showcase a lifecycle hook.
* fix service account key data source name
* switch id to name
* update docs
* doc format
* fixes for validation and tests
* last fixes for service account key data source
Many of the d.Set calls do not handle the error that comes back. This can lead
to things that appear to be set but are silently failing. This change adds a
flag to the makefile to force a panic if there are unhandled errors.
I largely stole these from github.com/terraform-providers/terraform-provider-aws, but with a few changes:
* I called out how we assign users to issues, to make it more transparent to users.
* I added a "success story" issue that will be automatically closed and labeled, to keep track of those stories.
* I added a `[issue-type:TYPE]` string to each, so hashibot can detect and act on them.
`govendor fetch github.com/hashicorp/terraform/...@v0.11.8`
I figured this was a good time to do it since we just had a release. I verified that everything still compiles and that a few tests are passing- I don't expect anything else to change, but if there are any weird failures that this exposes we'll catch them in CI with plenty of time before the next release.
