closer to our regular style now. And a fair bit simpler.
Structural
- Added an installer and moved all the default messages into it
so that they're part of the install process.
- Got rid of the model; you don't need to add an ecard entry in
the database to send an ecard. You just need to send a mail.
- Renamed the form and controller methods to reflect the fact that
we're sending an ecard, not adding an ecard to the db.
- Stopped inlining all of the code into the page like we do in
comments, and instead put it into a dialog box with a button
in the sidebar. This lets us ditch the extra .js and .css and
greatly simplifies the code.
General
- Added rules to the send_ecard form so that the validation
code has something to chew on.
- Renamed ecard::can_ecard() to ecard::can_send_ecard() cause you
should have a verb in there.
- Moved the can_send_ecard() check into ecard_theme::sidebar_bottom
and out of ecards.html.php
Style cleanup
- Changed "Title Casing" to "Sentence casing" everywhere for
consistency with our style.
- Cleaned up some indentation
- Got rid of carriage returns
LEFT TO DO:
1) Rename Ecards_Controller to Ecard_Controller for consistency (and
put it in ecard.php)
2) Actually have it send the ecard :-)