mirror of
https://github.com/letic/terraform-provider-google.git
synced 2024-06-29 06:42:36 +00:00
f9d0570168
* Fix bug where scheduling.automatic_restart false is never used * Remove deprecated automatic_restart value in favor of scheduling.automatic_restart * Remove deprecated on_host_maintenance * Correct bad var name * Re-add removed schema values and marked as Removed * Fix var to snake case * Migrate empty scheduling blocks in compute_instance_template * Shorten error message * Use only one return value instead of two
59 lines
2.1 KiB
Go
59 lines
2.1 KiB
Go
package google
|
|
|
|
import (
|
|
"fmt"
|
|
"log"
|
|
|
|
"github.com/hashicorp/terraform/terraform"
|
|
)
|
|
|
|
func resourceComputeInstanceTemplateMigrateState(
|
|
v int, is *terraform.InstanceState, meta interface{}) (*terraform.InstanceState, error) {
|
|
if is.Empty() {
|
|
log.Println("[DEBUG] Empty InstanceState; nothing to migrate.")
|
|
return is, nil
|
|
}
|
|
|
|
switch v {
|
|
case 0:
|
|
log.Println("[INFO] Found Compute Instance Template State v0; migrating to v1")
|
|
return migrateComputeInstanceTemplateStateV0toV1(is)
|
|
default:
|
|
return is, fmt.Errorf("Unexpected schema version: %d", v)
|
|
}
|
|
}
|
|
|
|
func migrateComputeInstanceTemplateStateV0toV1(is *terraform.InstanceState) (*terraform.InstanceState, error) {
|
|
log.Printf("[DEBUG] Attributes before migration: %#v", is.Attributes)
|
|
|
|
// automatic_restart is stored in two places. The top-level automatic_restart value is deprecated, so let's delete
|
|
// it from the state map for now. For paranoia's sake, we compare it to the value stored in scheduling as well.
|
|
ar := is.Attributes["automatic_restart"]
|
|
delete(is.Attributes, "automatic_restart")
|
|
|
|
schedulingCount, ok := is.Attributes["scheduling.#"]
|
|
if ok && schedulingCount != "0" && schedulingCount != "1" {
|
|
return nil, fmt.Errorf("Found multiple scheduling blocks when there should only be one")
|
|
}
|
|
|
|
if !ok || schedulingCount == "0" {
|
|
// Either scheduling is missing or empty; go ahead and add
|
|
is.Attributes["scheduling.#"] = "1"
|
|
is.Attributes["scheduling.0.automatic_restart"] = ar
|
|
}
|
|
|
|
schedAr := is.Attributes["scheduling.0.automatic_restart"]
|
|
if ar != schedAr {
|
|
// Here we could try to choose one value over the other, but in reality they should never be out of sync; error
|
|
// for now
|
|
return nil, fmt.Errorf("Found differing values for automatic_restart in state, unsure how to proceed. automatic_restart = %#v, scheduling.0.automatic_restart = %#v", ar, schedAr)
|
|
}
|
|
|
|
// We also nuke "on_host_maintenance" as it's been deprecated as well. Here we don't check the current value though
|
|
// as the authoritative value has always been maintained in the scheduling block.
|
|
delete(is.Attributes, "on_host_maintenance")
|
|
|
|
log.Printf("[DEBUG] Attributes after migration: %#v", is.Attributes)
|
|
return is, nil
|
|
}
|