mirror of
https://github.com/letic/terraform-provider-google.git
synced 2024-10-06 02:31:05 +00:00
0bcb01266c
Adds support for log exclusions in billingAccounts, organizations, folders and projects, see: https://cloud.google.com/logging/docs/exclusions ``` ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./google -v -run=Exclusion -timeout 120m === RUN TestAccLoggingBillingAccountExclusion_basic === PAUSE TestAccLoggingBillingAccountExclusion_basic === RUN TestAccLoggingBillingAccountExclusion_update === PAUSE TestAccLoggingBillingAccountExclusion_update === RUN TestAccLoggingFolderExclusion_basic === PAUSE TestAccLoggingFolderExclusion_basic === RUN TestAccLoggingFolderExclusion_folderAcceptsFullFolderPath === PAUSE TestAccLoggingFolderExclusion_folderAcceptsFullFolderPath === RUN TestAccLoggingFolderExclusion_update === PAUSE TestAccLoggingFolderExclusion_update === RUN TestAccLoggingOrganizationExclusion_basic === PAUSE TestAccLoggingOrganizationExclusion_basic === RUN TestAccLoggingOrganizationExclusion_update === PAUSE TestAccLoggingOrganizationExclusion_update === RUN TestAccLoggingProjectExclusion_basic === PAUSE TestAccLoggingProjectExclusion_basic === RUN TestAccLoggingProjectExclusion_disablePreservesFilter === PAUSE TestAccLoggingProjectExclusion_disablePreservesFilter === RUN TestAccLoggingProjectExclusion_update === PAUSE TestAccLoggingProjectExclusion_update === CONT TestAccLoggingBillingAccountExclusion_basic === CONT TestAccLoggingOrganizationExclusion_update === CONT TestAccLoggingProjectExclusion_update === CONT TestAccLoggingFolderExclusion_folderAcceptsFullFolderPath === CONT TestAccLoggingOrganizationExclusion_basic --- PASS: TestAccLoggingProjectExclusion_update (3.60s) --- PASS: TestAccLoggingOrganizationExclusion_update (4.40s) === CONT TestAccLoggingFolderExclusion_update --- PASS: TestAccLoggingOrganizationExclusion_basic (1.90s) === CONT TestAccLoggingFolderExclusion_basic --- PASS: TestAccLoggingBillingAccountExclusion_basic (6.21s) === CONT TestAccLoggingBillingAccountExclusion_update --- PASS: TestAccLoggingBillingAccountExclusion_update (5.90s) === CONT TestAccLoggingProjectExclusion_disablePreservesFilter --- PASS: TestAccLoggingProjectExclusion_disablePreservesFilter (3.90s) === CONT TestAccLoggingProjectExclusion_basic --- PASS: TestAccLoggingFolderExclusion_folderAcceptsFullFolderPath (16.67s) --- PASS: TestAccLoggingProjectExclusion_basic (1.96s) --- PASS: TestAccLoggingFolderExclusion_basic (15.30s) --- PASS: TestAccLoggingFolderExclusion_update (18.35s) PASS ok github.com/terraform-providers/terraform-provider-google/google 22.810s ```
241 lines
8.1 KiB
Go
241 lines
8.1 KiB
Go
package google
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/hashicorp/terraform/helper/acctest"
|
|
"github.com/hashicorp/terraform/helper/resource"
|
|
"github.com/hashicorp/terraform/terraform"
|
|
"google.golang.org/api/logging/v2"
|
|
)
|
|
|
|
func TestAccLoggingFolderExclusion_basic(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
org := getTestOrgFromEnv(t)
|
|
exclusionName := "tf-test-exclusion-" + acctest.RandString(10)
|
|
folderName := "tf-test-folder-" + acctest.RandString(10)
|
|
description := "Description " + acctest.RandString(10)
|
|
|
|
var exclusion logging.LogExclusion
|
|
|
|
resource.Test(t, resource.TestCase{
|
|
PreCheck: func() { testAccPreCheck(t) },
|
|
Providers: testAccProviders,
|
|
CheckDestroy: testAccCheckLoggingFolderExclusionDestroy,
|
|
Steps: []resource.TestStep{
|
|
{
|
|
Config: testAccLoggingFolderExclusion_basic(exclusionName, description, folderName, "organizations/"+org),
|
|
Check: resource.ComposeTestCheckFunc(
|
|
testAccCheckLoggingFolderExclusionExists("google_logging_folder_exclusion.basic", &exclusion),
|
|
testAccCheckLoggingFolderExclusion(&exclusion, "google_logging_folder_exclusion.basic"),
|
|
),
|
|
},
|
|
{
|
|
ResourceName: "google_logging_folder_exclusion.basic",
|
|
ImportState: true,
|
|
ImportStateVerify: true,
|
|
},
|
|
},
|
|
})
|
|
}
|
|
|
|
func TestAccLoggingFolderExclusion_folderAcceptsFullFolderPath(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
org := getTestOrgFromEnv(t)
|
|
exclusionName := "tf-test-exclusion-" + acctest.RandString(10)
|
|
folderName := "tf-test-folder-" + acctest.RandString(10)
|
|
description := "Description " + acctest.RandString(10)
|
|
|
|
var exclusion logging.LogExclusion
|
|
|
|
checkFn := func(s []*terraform.InstanceState) error {
|
|
loggingExclusionId, err := parseLoggingExclusionId(s[0].ID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
folderAttribute := s[0].Attributes["folder"]
|
|
if loggingExclusionId.resourceId != folderAttribute {
|
|
return fmt.Errorf("imported folder id does not match: actual = %#v expected = %#v", folderAttribute, loggingExclusionId.resourceId)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
resource.Test(t, resource.TestCase{
|
|
PreCheck: func() { testAccPreCheck(t) },
|
|
Providers: testAccProviders,
|
|
CheckDestroy: testAccCheckLoggingFolderExclusionDestroy,
|
|
Steps: []resource.TestStep{
|
|
{
|
|
Config: testAccLoggingFolderExclusion_withFullFolderPath(exclusionName, description, folderName, "organizations/"+org),
|
|
Check: resource.ComposeTestCheckFunc(
|
|
testAccCheckLoggingFolderExclusionExists("google_logging_folder_exclusion.full-folder", &exclusion),
|
|
testAccCheckLoggingFolderExclusion(&exclusion, "google_logging_folder_exclusion.full-folder"),
|
|
),
|
|
},
|
|
{
|
|
ResourceName: "google_logging_folder_exclusion.full-folder",
|
|
ImportState: true,
|
|
ImportStateVerify: true,
|
|
// We support both notations: folder/[FOLDER_ID] and plain [FOLDER_ID] however the
|
|
// importer will always use the plain [FOLDER_ID] notation which will differ from
|
|
// the schema if the schema has used the prefixed notation. We have to check this in
|
|
// a checkFn instead.
|
|
ImportStateVerifyIgnore: []string{"folder"},
|
|
ImportStateCheck: checkFn,
|
|
},
|
|
},
|
|
})
|
|
}
|
|
|
|
func TestAccLoggingFolderExclusion_update(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
org := getTestOrgFromEnv(t)
|
|
exclusionName := "tf-test-exclusion-" + acctest.RandString(10)
|
|
folderName := "tf-test-folder-" + acctest.RandString(10)
|
|
parent := "organizations/" + org
|
|
descriptionBefore := "Basic Folder Logging Exclusion" + acctest.RandString(10)
|
|
descriptionAfter := "Updated Basic Folder Logging Exclusion" + acctest.RandString(10)
|
|
|
|
var exclusionBefore, exclusionAfter logging.LogExclusion
|
|
|
|
resource.Test(t, resource.TestCase{
|
|
PreCheck: func() { testAccPreCheck(t) },
|
|
Providers: testAccProviders,
|
|
CheckDestroy: testAccCheckLoggingFolderExclusionDestroy,
|
|
Steps: []resource.TestStep{
|
|
{
|
|
Config: testAccLoggingFolderExclusion_basic(exclusionName, descriptionBefore, folderName, parent),
|
|
Check: resource.ComposeTestCheckFunc(
|
|
testAccCheckLoggingFolderExclusionExists("google_logging_folder_exclusion.basic", &exclusionBefore),
|
|
testAccCheckLoggingFolderExclusion(&exclusionBefore, "google_logging_folder_exclusion.basic"),
|
|
),
|
|
},
|
|
{
|
|
Config: testAccLoggingFolderExclusion_basic(exclusionName, descriptionAfter, folderName, parent),
|
|
Check: resource.ComposeTestCheckFunc(
|
|
testAccCheckLoggingFolderExclusionExists("google_logging_folder_exclusion.basic", &exclusionAfter),
|
|
testAccCheckLoggingFolderExclusion(&exclusionAfter, "google_logging_folder_exclusion.basic"),
|
|
),
|
|
},
|
|
{
|
|
ResourceName: "google_logging_folder_exclusion.basic",
|
|
ImportState: true,
|
|
ImportStateVerify: true,
|
|
},
|
|
},
|
|
})
|
|
|
|
// Description should have changed, but Filter and Disabled should be the same
|
|
if exclusionBefore.Description == exclusionAfter.Description {
|
|
t.Errorf("Expected Description to change, but it didn't: Description = %#v", exclusionBefore.Description)
|
|
}
|
|
if exclusionBefore.Filter != exclusionAfter.Filter {
|
|
t.Errorf("Expected Filter to be the same, but it differs: before = %#v, after = %#v",
|
|
exclusionBefore.Filter, exclusionAfter.Filter)
|
|
}
|
|
if exclusionBefore.Disabled != exclusionAfter.Disabled {
|
|
t.Errorf("Expected Disabled to be the same, but it differs: before = %#v, after = %#v",
|
|
exclusionBefore.Disabled, exclusionAfter.Disabled)
|
|
}
|
|
}
|
|
|
|
func testAccCheckLoggingFolderExclusionDestroy(s *terraform.State) error {
|
|
config := testAccProvider.Meta().(*Config)
|
|
|
|
for _, rs := range s.RootModule().Resources {
|
|
if rs.Type != "google_logging_folder_exclusion" {
|
|
continue
|
|
}
|
|
|
|
attributes := rs.Primary.Attributes
|
|
|
|
_, err := config.clientLogging.Folders.Exclusions.Get(attributes["id"]).Do()
|
|
if err == nil {
|
|
return fmt.Errorf("folder exclusion still exists")
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func testAccCheckLoggingFolderExclusionExists(n string, exclusion *logging.LogExclusion) resource.TestCheckFunc {
|
|
return func(s *terraform.State) error {
|
|
attributes, err := getResourceAttributes(n, s)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
config := testAccProvider.Meta().(*Config)
|
|
|
|
si, err := config.clientLogging.Folders.Exclusions.Get(attributes["id"]).Do()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
*exclusion = *si
|
|
|
|
return nil
|
|
}
|
|
}
|
|
|
|
func testAccCheckLoggingFolderExclusion(exclusion *logging.LogExclusion, n string) resource.TestCheckFunc {
|
|
return func(s *terraform.State) error {
|
|
attributes, err := getResourceAttributes(n, s)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if exclusion.Description != attributes["description"] {
|
|
return fmt.Errorf("mismatch on description: api has %s but client has %s", exclusion.Description, attributes["description"])
|
|
}
|
|
|
|
if exclusion.Filter != attributes["filter"] {
|
|
return fmt.Errorf("mismatch on filter: api has %s but client has %s", exclusion.Filter, attributes["filter"])
|
|
}
|
|
|
|
disabledAttribute, err := toBool(attributes["disabled"])
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if exclusion.Disabled != disabledAttribute {
|
|
return fmt.Errorf("mismatch on disabled: api has %t but client has %t", exclusion.Disabled, disabledAttribute)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
}
|
|
|
|
func testAccLoggingFolderExclusion_basic(exclusionName, description, folderName, folderParent string) string {
|
|
return fmt.Sprintf(`
|
|
resource "google_logging_folder_exclusion" "basic" {
|
|
name = "%s"
|
|
folder = "${element(split("/", google_folder.my-folder.name), 1)}"
|
|
description = "%s"
|
|
filter = "logName=\"projects/%s/logs/compute.googleapis.com%%2Factivity_log\" AND severity>=ERROR"
|
|
}
|
|
|
|
resource "google_folder" "my-folder" {
|
|
display_name = "%s"
|
|
parent = "%s"
|
|
}`, exclusionName, description, getTestProjectFromEnv(), folderName, folderParent)
|
|
}
|
|
|
|
func testAccLoggingFolderExclusion_withFullFolderPath(exclusionName, description, folderName, folderParent string) string {
|
|
return fmt.Sprintf(`
|
|
resource "google_logging_folder_exclusion" "full-folder" {
|
|
name = "%s"
|
|
folder = "${google_folder.my-folder.name}"
|
|
description = "%s"
|
|
filter = "logName=\"projects/%s/logs/compute.googleapis.com%%2Factivity_log\" AND severity>=ERROR"
|
|
}
|
|
|
|
resource "google_folder" "my-folder" {
|
|
display_name = "%s"
|
|
parent = "%s"
|
|
}`, exclusionName, description, getTestProjectFromEnv(), folderName, folderParent)
|
|
}
|