mirror of
https://github.com/letic/terraform-provider-google.git
synced 2024-09-06 09:06:44 +00:00
![Riley Karson](/assets/img/avatar_default.png)
Fixes #1494. * Add import support for `google_logging_organization_sink`, `google_logging_folder_sink`, `google_logging_billing_account_sink`. Using `StateFunc` over `DiffSuppressFunc` should only affect tests; for some reason `TestAccLoggingFolderSink_folderAcceptsFullFolderPath` expected a `folder` value of `folders/{{id}}` vs expecting `{{id}}` when only `DiffSuppressFunc` was used, when in real use `DiffSuppressFunc` should be sufficient.
288 lines
9.0 KiB
Go
288 lines
9.0 KiB
Go
package google
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/hashicorp/terraform/helper/acctest"
|
|
"github.com/hashicorp/terraform/helper/resource"
|
|
"github.com/hashicorp/terraform/terraform"
|
|
"google.golang.org/api/logging/v2"
|
|
"strconv"
|
|
)
|
|
|
|
func TestAccLoggingFolderSink_basic(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
org := getTestOrgFromEnv(t)
|
|
sinkName := "tf-test-sink-" + acctest.RandString(10)
|
|
bucketName := "tf-test-sink-bucket-" + acctest.RandString(10)
|
|
folderName := "tf-test-folder-" + acctest.RandString(10)
|
|
|
|
var sink logging.LogSink
|
|
|
|
resource.Test(t, resource.TestCase{
|
|
PreCheck: func() { testAccPreCheck(t) },
|
|
Providers: testAccProviders,
|
|
CheckDestroy: testAccCheckLoggingFolderSinkDestroy,
|
|
Steps: []resource.TestStep{
|
|
{
|
|
Config: testAccLoggingFolderSink_basic(sinkName, bucketName, folderName, "organizations/"+org),
|
|
Check: resource.ComposeTestCheckFunc(
|
|
testAccCheckLoggingFolderSinkExists("google_logging_folder_sink.basic", &sink),
|
|
testAccCheckLoggingFolderSink(&sink, "google_logging_folder_sink.basic"),
|
|
),
|
|
}, {
|
|
ResourceName: "google_logging_folder_sink.basic",
|
|
ImportState: true,
|
|
ImportStateVerify: true,
|
|
},
|
|
},
|
|
})
|
|
}
|
|
|
|
func TestAccLoggingFolderSink_folderAcceptsFullFolderPath(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
org := getTestOrgFromEnv(t)
|
|
sinkName := "tf-test-sink-" + acctest.RandString(10)
|
|
bucketName := "tf-test-sink-bucket-" + acctest.RandString(10)
|
|
folderName := "tf-test-folder-" + acctest.RandString(10)
|
|
|
|
var sink logging.LogSink
|
|
|
|
resource.Test(t, resource.TestCase{
|
|
PreCheck: func() { testAccPreCheck(t) },
|
|
Providers: testAccProviders,
|
|
CheckDestroy: testAccCheckLoggingFolderSinkDestroy,
|
|
Steps: []resource.TestStep{
|
|
{
|
|
Config: testAccLoggingFolderSink_withFullFolderPath(sinkName, bucketName, folderName, "organizations/"+org),
|
|
Check: resource.ComposeTestCheckFunc(
|
|
testAccCheckLoggingFolderSinkExists("google_logging_folder_sink.basic", &sink),
|
|
testAccCheckLoggingFolderSink(&sink, "google_logging_folder_sink.basic"),
|
|
),
|
|
}, {
|
|
ResourceName: "google_logging_folder_sink.basic",
|
|
ImportState: true,
|
|
ImportStateVerify: true,
|
|
},
|
|
},
|
|
})
|
|
}
|
|
|
|
func TestAccLoggingFolderSink_update(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
org := getTestOrgFromEnv(t)
|
|
sinkName := "tf-test-sink-" + acctest.RandString(10)
|
|
bucketName := "tf-test-sink-bucket-" + acctest.RandString(10)
|
|
updatedBucketName := "tf-test-sink-bucket-" + acctest.RandString(10)
|
|
folderName := "tf-test-folder-" + acctest.RandString(10)
|
|
parent := "organizations/" + org
|
|
|
|
var sinkBefore, sinkAfter logging.LogSink
|
|
|
|
resource.Test(t, resource.TestCase{
|
|
PreCheck: func() { testAccPreCheck(t) },
|
|
Providers: testAccProviders,
|
|
CheckDestroy: testAccCheckLoggingFolderSinkDestroy,
|
|
Steps: []resource.TestStep{
|
|
{
|
|
Config: testAccLoggingFolderSink_basic(sinkName, bucketName, folderName, parent),
|
|
Check: resource.ComposeTestCheckFunc(
|
|
testAccCheckLoggingFolderSinkExists("google_logging_folder_sink.basic", &sinkBefore),
|
|
testAccCheckLoggingFolderSink(&sinkBefore, "google_logging_folder_sink.basic"),
|
|
),
|
|
}, {
|
|
Config: testAccLoggingFolderSink_basic(sinkName, updatedBucketName, folderName, parent),
|
|
Check: resource.ComposeTestCheckFunc(
|
|
testAccCheckLoggingFolderSinkExists("google_logging_folder_sink.basic", &sinkAfter),
|
|
testAccCheckLoggingFolderSink(&sinkAfter, "google_logging_folder_sink.basic"),
|
|
),
|
|
}, {
|
|
ResourceName: "google_logging_folder_sink.basic",
|
|
ImportState: true,
|
|
ImportStateVerify: true,
|
|
},
|
|
},
|
|
})
|
|
|
|
// Destination should have changed, but WriterIdentity should be the same
|
|
if sinkBefore.Destination == sinkAfter.Destination {
|
|
t.Errorf("Expected Destination to change, but it didn't: Destination = %#v", sinkBefore.Destination)
|
|
}
|
|
if sinkBefore.WriterIdentity != sinkAfter.WriterIdentity {
|
|
t.Errorf("Expected WriterIdentity to be the same, but it differs: before = %#v, after = %#v",
|
|
sinkBefore.WriterIdentity, sinkAfter.WriterIdentity)
|
|
}
|
|
}
|
|
|
|
func TestAccLoggingFolderSink_heredoc(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
org := getTestOrgFromEnv(t)
|
|
sinkName := "tf-test-sink-" + acctest.RandString(10)
|
|
bucketName := "tf-test-sink-bucket-" + acctest.RandString(10)
|
|
folderName := "tf-test-folder-" + acctest.RandString(10)
|
|
|
|
var sink logging.LogSink
|
|
|
|
resource.Test(t, resource.TestCase{
|
|
PreCheck: func() { testAccPreCheck(t) },
|
|
Providers: testAccProviders,
|
|
CheckDestroy: testAccCheckLoggingFolderSinkDestroy,
|
|
Steps: []resource.TestStep{
|
|
{
|
|
Config: testAccLoggingFolderSink_heredoc(sinkName, bucketName, folderName, "organizations/"+org),
|
|
Check: resource.ComposeTestCheckFunc(
|
|
testAccCheckLoggingFolderSinkExists("google_logging_folder_sink.heredoc", &sink),
|
|
testAccCheckLoggingFolderSink(&sink, "google_logging_folder_sink.heredoc"),
|
|
),
|
|
}, {
|
|
ResourceName: "google_logging_folder_sink.heredoc",
|
|
ImportState: true,
|
|
ImportStateVerify: true,
|
|
},
|
|
},
|
|
})
|
|
}
|
|
|
|
func testAccCheckLoggingFolderSinkDestroy(s *terraform.State) error {
|
|
config := testAccProvider.Meta().(*Config)
|
|
|
|
for _, rs := range s.RootModule().Resources {
|
|
if rs.Type != "google_logging_folder_sink" {
|
|
continue
|
|
}
|
|
|
|
attributes := rs.Primary.Attributes
|
|
|
|
_, err := config.clientLogging.Folders.Sinks.Get(attributes["id"]).Do()
|
|
if err == nil {
|
|
return fmt.Errorf("folder sink still exists")
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func testAccCheckLoggingFolderSinkExists(n string, sink *logging.LogSink) resource.TestCheckFunc {
|
|
return func(s *terraform.State) error {
|
|
attributes, err := getResourceAttributes(n, s)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
config := testAccProvider.Meta().(*Config)
|
|
|
|
si, err := config.clientLogging.Folders.Sinks.Get(attributes["id"]).Do()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
*sink = *si
|
|
|
|
return nil
|
|
}
|
|
}
|
|
|
|
func testAccCheckLoggingFolderSink(sink *logging.LogSink, n string) resource.TestCheckFunc {
|
|
return func(s *terraform.State) error {
|
|
attributes, err := getResourceAttributes(n, s)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if sink.Destination != attributes["destination"] {
|
|
return fmt.Errorf("mismatch on destination: api has %s but client has %s", sink.Destination, attributes["destination"])
|
|
}
|
|
|
|
if sink.Filter != attributes["filter"] {
|
|
return fmt.Errorf("mismatch on filter: api has %s but client has %s", sink.Filter, attributes["filter"])
|
|
}
|
|
|
|
if sink.WriterIdentity != attributes["writer_identity"] {
|
|
return fmt.Errorf("mismatch on writer_identity: api has %s but client has %s", sink.WriterIdentity, attributes["writer_identity"])
|
|
}
|
|
|
|
includeChildren := false
|
|
if attributes["include_children"] != "" {
|
|
includeChildren, err = strconv.ParseBool(attributes["include_children"])
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
if sink.IncludeChildren != includeChildren {
|
|
return fmt.Errorf("mismatch on include_children: api has %v but client has %v", sink.IncludeChildren, includeChildren)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
}
|
|
|
|
func testAccLoggingFolderSink_basic(sinkName, bucketName, folderName, folderParent string) string {
|
|
return fmt.Sprintf(`
|
|
resource "google_logging_folder_sink" "basic" {
|
|
name = "%s"
|
|
folder = "${element(split("/", google_folder.my-folder.name), 1)}"
|
|
destination = "storage.googleapis.com/${google_storage_bucket.log-bucket.name}"
|
|
filter = "logName=\"projects/%s/logs/compute.googleapis.com%%2Factivity_log\" AND severity>=ERROR"
|
|
include_children = true
|
|
}
|
|
|
|
resource "google_storage_bucket" "log-bucket" {
|
|
name = "%s"
|
|
}
|
|
|
|
resource "google_folder" "my-folder" {
|
|
display_name = "%s"
|
|
parent = "%s"
|
|
}`, sinkName, getTestProjectFromEnv(), bucketName, folderName, folderParent)
|
|
}
|
|
|
|
func testAccLoggingFolderSink_withFullFolderPath(sinkName, bucketName, folderName, folderParent string) string {
|
|
return fmt.Sprintf(`
|
|
resource "google_logging_folder_sink" "basic" {
|
|
name = "%s"
|
|
folder = "${google_folder.my-folder.name}"
|
|
destination = "storage.googleapis.com/${google_storage_bucket.log-bucket.name}"
|
|
filter = "logName=\"projects/%s/logs/compute.googleapis.com%%2Factivity_log\" AND severity>=ERROR"
|
|
include_children = false
|
|
}
|
|
|
|
resource "google_storage_bucket" "log-bucket" {
|
|
name = "%s"
|
|
}
|
|
|
|
resource "google_folder" "my-folder" {
|
|
display_name = "%s"
|
|
parent = "%s"
|
|
}`, sinkName, getTestProjectFromEnv(), bucketName, folderName, folderParent)
|
|
}
|
|
|
|
func testAccLoggingFolderSink_heredoc(sinkName, bucketName, folderName, folderParent string) string {
|
|
return fmt.Sprintf(`
|
|
resource "google_logging_folder_sink" "heredoc" {
|
|
name = "%s"
|
|
folder = "${element(split("/", google_folder.my-folder.name), 1)}"
|
|
destination = "storage.googleapis.com/${google_storage_bucket.log-bucket.name}"
|
|
filter = <<EOS
|
|
|
|
logName="projects/%s/logs/compute.googleapis.com%%2Factivity_log"
|
|
AND severity>=ERROR
|
|
|
|
|
|
|
|
EOS
|
|
include_children = true
|
|
}
|
|
|
|
resource "google_storage_bucket" "log-bucket" {
|
|
name = "%s"
|
|
}
|
|
|
|
resource "google_folder" "my-folder" {
|
|
display_name = "%s"
|
|
parent = "%s"
|
|
}`, sinkName, getTestProjectFromEnv(), bucketName, folderName, folderParent)
|
|
}
|