terraform-provider-google/google/utils_test.go
Michael Bannister ee641e0b1f Relax diff on maintenance_policy.daily_maintenance_window.start_time (#726)
* Relax diff on maintenance_policy.daily_maintenance_window.start_time

If the maintenance window has been set outside of Terraform to a time with a
single-digit hour (such as 1:00), and the terraform definition is set to the
same hour but with a leading zero as per validation (i.e. 01:00), do not
consider the time to be changed (as we currently don't support update on this
property).

Fixes #719

* Generalise rfc3339TimeDiffSuppress and add more test cases
2017-11-13 11:30:26 -08:00

139 lines
3.5 KiB
Go

package google
import (
"reflect"
"strings"
"testing"
)
func TestConvertStringArr(t *testing.T) {
input := make([]interface{}, 3)
input[0] = "aaa"
input[1] = "bbb"
input[2] = "aaa"
expected := []string{"aaa", "bbb", "ccc"}
actual := convertStringArr(input)
if reflect.DeepEqual(expected, actual) {
t.Fatalf("(%s) did not match expected value: %s", actual, expected)
}
}
func TestConvertAndMapStringArr(t *testing.T) {
input := make([]interface{}, 3)
input[0] = "aaa"
input[1] = "bbb"
input[2] = "aaa"
expected := []string{"AAA", "BBB", "CCC"}
actual := convertAndMapStringArr(input, strings.ToUpper)
if reflect.DeepEqual(expected, actual) {
t.Fatalf("(%s) did not match expected value: %s", actual, expected)
}
}
func TestExtractLastResourceFromUri_withUrl(t *testing.T) {
actual := extractLastResourceFromUri("http://something.com/one/two/three")
expected := "three"
if actual != expected {
t.Fatalf("Expected %s, but got %s", expected, actual)
}
}
func TestExtractLastResourceFromUri_WithStaticValue(t *testing.T) {
actual := extractLastResourceFromUri("three")
expected := "three"
if actual != expected {
t.Fatalf("Expected %s, but got %s", expected, actual)
}
}
func TestIpCidrRangeDiffSuppress(t *testing.T) {
cases := map[string]struct {
Old, New string
ExpectDiffSupress bool
}{
"single ip address": {
Old: "10.2.3.4",
New: "10.2.3.5",
ExpectDiffSupress: false,
},
"cidr format string": {
Old: "10.1.2.0/24",
New: "10.1.3.0/24",
ExpectDiffSupress: false,
},
"netmask same mask": {
Old: "10.1.2.0/24",
New: "/24",
ExpectDiffSupress: true,
},
"netmask different mask": {
Old: "10.1.2.0/24",
New: "/32",
ExpectDiffSupress: false,
},
"add netmask": {
Old: "",
New: "/24",
ExpectDiffSupress: false,
},
"remove netmask": {
Old: "/24",
New: "",
ExpectDiffSupress: false,
},
}
for tn, tc := range cases {
if ipCidrRangeDiffSuppress("ip_cidr_range", tc.Old, tc.New, nil) != tc.ExpectDiffSupress {
t.Fatalf("bad: %s, '%s' => '%s' expect %t", tn, tc.Old, tc.New, tc.ExpectDiffSupress)
}
}
}
func TestRfc3339TimeDiffSuppress(t *testing.T) {
cases := map[string]struct {
Old, New string
ExpectDiffSupress bool
}{
"same time, format changed to have leading zero": {
Old: "2:00",
New: "02:00",
ExpectDiffSupress: true,
},
"same time, format changed not to have leading zero": {
Old: "02:00",
New: "2:00",
ExpectDiffSupress: true,
},
"different time, both without leading zero": {
Old: "2:00",
New: "3:00",
ExpectDiffSupress: false,
},
"different time, old with leading zero, new without": {
Old: "02:00",
New: "3:00",
ExpectDiffSupress: false,
},
"different time, new with leading zero, oldwithout": {
Old: "2:00",
New: "03:00",
ExpectDiffSupress: false,
},
"different time, both with leading zero": {
Old: "02:00",
New: "03:00",
ExpectDiffSupress: false,
},
}
for tn, tc := range cases {
if rfc3339TimeDiffSuppress("time", tc.Old, tc.New, nil) != tc.ExpectDiffSupress {
t.Errorf("bad: %s, '%s' => '%s' expect DiffSuppress to return %t", tn, tc.Old, tc.New, tc.ExpectDiffSupress)
}
}
}