public/terraform-provider-google
0
0
Fork 0
mirror of https://github.com/letic/terraform-provider-google.git synced 2024-07-24 18:46:00 +00:00
Code Issues Projects Releases Wiki Activity
2b1b668953
terraform-provider-google/website/docs/r
History
Darren Haken 2b1b668953 #1300 Supporting regional clusters for node pools (#1320) 
This PR also switched us to using the beta API in all cases, and that had a side effect which is worth noting, note included here for posterity.

=====
The problem is, we add a GPU, and as per the docs, GKE adds a taint to
the node pool saying "don't schedule here unless you tolerate GPUs",
which is pretty sensible.

Terraform doesn't know about that, because it didn't ask for the taint
to be added. So after apply, on refresh, it sees the state of the world
(1 taint) and the state of the config (0 taints) and wants to set the
world equal to the config. This introduces a diff, which makes the test
fail - tests fail if there's a diff after they run.

Taints are a beta feature, though. :) And since the config doesn't
contain any taints, terraform didn't see any beta features in that node
pool ... so it used to send the request to the v1 API. And since the v1
API didn't return anything about taints (since they're a beta feature),
terraform happily checked the state of the world (0 taints I know about)
vs the config (0 taints), and all was well.

This PR makes every node pool refresh request hit the beta API. So now
terraform finds out about the taints (which were always there) and the
test fails (which it always should have done).

The solution is probably to write a little bit of code which suppresses
the report of the diff of any taint with value 'nvidia.com/gpu', but
only if GPUs are enabled. I think that's something that can be done.
2018-04-24 17:55:21 -07:00
..
bigquery_dataset.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
bigquery_table.html.markdown Add time partitioning field to google_bigquery_table resource (#1240) 2018-03-30 10:15:06 -07:00
bigtable_instance.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
bigtable_table.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
cloudfunctions_function.html.markdown Adding description of Cloud Functions to website (#958) 2018-01-19 11:33:07 -08:00
cloudiot_registry.html.markdown Add support for Google Cloud IoT Core registry (#970) 2018-01-24 13:03:09 -08:00
compute_address.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
compute_autoscaler.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
compute_backend_bucket.html.markdown Magic Modules changes. (#1362) 2018-04-19 15:48:25 -07:00
compute_backend_service.html.markdown Add max_connections and max_connections_per_instance to backend service (#1353) 2018-04-19 14:00:34 -07:00
compute_disk.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
compute_firewall.html.markdown Typo in the documentation (#1330) 2018-04-13 11:39:12 -07:00
compute_forwarding_rule.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
compute_global_address.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
compute_global_forwarding_rule.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
compute_health_check.html.markdown Fix read method + test/document import for google_compute_health_check (#155) 2017-06-26 18:25:22 +03:00
compute_http_health_check.html.markdown Magic Modules changes. (#1362) 2018-04-19 15:48:25 -07:00
compute_https_health_check.html.markdown Magic Modules changes. (#1362) 2018-04-19 15:48:25 -07:00
compute_image.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
compute_instance_group_manager.html.markdown Add missing markdown rulers (#1319) 2018-04-11 15:21:48 -07:00
compute_instance_group.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
compute_instance_template.html.markdown un-deprecate name_prefix for instance templates (#1328) 2018-04-12 16:08:31 -07:00
compute_instance.html.markdown Add DNS PTR record to Compute Instance (#1349) 2018-04-20 11:14:38 -07:00
compute_network_peering.html.markdown Add new resource google_compute_network_peering (#259) 2017-07-28 09:51:29 -07:00
compute_network.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
compute_project_metadata_item.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
compute_project_metadata.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
compute_region_autoscaler.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
compute_region_backend_service.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
compute_region_instance_group_manager.html.markdown Add missing markdown rulers (#1319) 2018-04-11 15:21:48 -07:00
compute_route.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
compute_router_interface.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
compute_router_peer.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
compute_router.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
compute_security_policy.html.markdown Add new google_compute_security_policy resource (#1242) 2018-03-21 16:52:23 -07:00
compute_shared_vpc_host_project.html.markdown Import google_compute_shared_vpc_host_project/google_compute_shared_vpc_service_project resources (#1004) 2018-01-24 12:54:42 -08:00
compute_shared_vpc_service_project.html.markdown Import google_compute_shared_vpc_host_project/google_compute_shared_vpc_service_project resources (#1004) 2018-01-24 12:54:42 -08:00
compute_snapshot.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
compute_ssl_certificate.html.markdown Deprecate name_prefix (#1035) 2018-04-02 10:28:59 -07:00
compute_ssl_policy.html.markdown New resource/datasource: SSL Policy (#1247) 2018-03-26 16:53:35 -07:00
compute_subnetwork_iam.html.markdown add subnetwork iam resources (#1305) 2018-04-06 17:38:48 -07:00
compute_subnetwork.html.markdown add subnetwork iam resources (#1305) 2018-04-06 17:38:48 -07:00
compute_target_http_proxy.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
compute_target_https_proxy.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
compute_target_pool.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
compute_target_ssl_proxy.html.markdown Release autogenerated google_compute_target_ssl_proxy resource (#1373) 2018-04-24 14:01:53 -07:00
compute_target_tcp_proxy.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
compute_url_map.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
compute_vpn_gateway.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
compute_vpn_tunnel.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
container_cluster.html.markdown Add support for regional GKE clusters in google_container_cluster (#1181) 2018-04-05 14:51:35 -07:00
container_node_pool.html.markdown #1300 Supporting regional clusters for node pools (#1320) 2018-04-24 17:55:21 -07:00
dataflow_job.html.markdown New Resource: Dataflow Job (#855) 2018-01-10 14:38:15 -08:00
dataproc_cluster.html.markdown Dataproc autogen bucket changes (#1171) 2018-03-13 11:46:27 -07:00
dataproc_job.html.markdown Add google_dataproc_job resource (#253) 2017-11-21 09:32:43 -08:00
dns_managed_zone.markdown Google managed zone dns_name argument requires a fully qualified domain name. 2018-04-09 14:51:04 -07:00
dns_record_set.markdown Add additional example usages to google_dns_record_set documentation (#1308) 2018-04-09 14:46:42 -07:00
endpoints_service.html.markdown Switch from protoc_output to protoc_output_base64. (#1290) 2018-04-17 13:00:37 -07:00
google_folder_iam_binding.html.markdown Add 'google_folder_iam_binding' and 'google_folder_iam_member' resources (#1076) 2018-02-13 12:49:51 -08:00
google_folder_iam_member.html.markdown Add 'google_folder_iam_binding' and 'google_folder_iam_member' resources (#1076) 2018-02-13 12:49:51 -08:00
google_folder_iam_policy.html.markdown Assign IAM policy to folder. (#447) 2017-09-25 11:30:45 -07:00
google_folder_organization_policy.html.markdown Correct usage of 'folders' for 'google_folder_organization_policy' resource. (#963) 2018-01-17 10:26:16 -08:00
google_folder.html.markdown Fix broken link to GCP Resource Manager's folder API doc. (#562) 2017-10-10 09:38:40 -07:00
google_kms_crypto_key_iam_binding.html.markdown Fix wrong resource type in CryptoKey/IAM binding doc (#1030) 2018-01-31 09:35:52 -08:00
google_kms_crypto_key_iam_member.html.markdown Fixed small typos in the doc, where the custom roles names should contain "projects|organizations" in plural form. (#1012) 2018-01-26 16:36:57 -08:00
google_kms_crypto_key.html.markdown Add google_kms_key_ring_iam_policy resource and improve iam docs (#814) 2017-12-06 09:33:21 -08:00
google_kms_key_ring_iam.html.markdown Fixed small typos in the doc, where the custom roles names should contain "projects|organizations" in plural form. (#1012) 2018-01-26 16:36:57 -08:00
google_kms_key_ring.html.markdown Add google_kms_key_ring_iam_policy resource and improve iam docs (#814) 2017-12-06 09:33:21 -08:00
google_organization_iam_binding.md Fixed small typos in the doc, where the custom roles names should contain "projects|organizations" in plural form. (#1012) 2018-01-26 16:36:57 -08:00
google_organization_iam_custom_role.html.markdown Add new resource to support IAM custom organization roles (#735) 2017-11-13 16:05:16 -08:00
google_organization_iam_member.md Fixed small typos in the doc, where the custom roles names should contain "projects|organizations" in plural form. (#1012) 2018-01-26 16:36:57 -08:00
google_organization_iam_policy.md Add the organization iam policy, with suitable warnings. (#1196) 2018-03-14 15:21:33 -07:00
google_organization_policy.html.markdown Use the correct resource type in the google_organization_policy examples. (#868) 2017-12-15 10:06:08 -08:00
google_project_iam_custom_role.html.markdown Fix wrong filename for project custom role documentation (#734) 2017-11-13 14:57:58 -08:00
google_project_iam.html.markdown consolidate iam docs, add a bit more for service account (#1227) 2018-03-20 17:06:54 -07:00
google_project_organization_policy.html.markdown google_project_organization_policy (#1226) 2018-03-26 12:45:32 -07:00
google_project_service.html.markdown Fix the example GCloud command line for listing the enabled APIs. (#1325) 2018-04-12 13:26:34 -07:00
google_project_services.html.markdown Fix the example GCloud command line for listing the enabled APIs. (#1325) 2018-04-12 13:26:34 -07:00
google_project.html.markdown Fix auto-delete default network in google_project. (#1336) 2018-04-16 10:25:49 -07:00
google_service_account_iam.html.markdown consolidate iam docs, add a bit more for service account (#1227) 2018-03-20 17:06:54 -07:00
google_service_account_key.html.markdown Update google_service_account_key.html.markdown (#1284) 2018-04-04 09:08:08 -07:00
google_service_account.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
logging_billing_account_sink.html.markdown fix link format (#673) 2017-11-03 09:45:48 -07:00
logging_folder_sink.html.markdown fix link format (#673) 2017-11-03 09:45:48 -07:00
logging_organization_sink.html.markdown Fix broken links on the website. 2018-01-18 14:07:24 -08:00
logging_project_sink.html.markdown Fix API link in logging docs 2018-03-26 10:28:33 -07:00
pubsub_subscription_iam.html.markdown Add IAM resources for pubsub subscriptions (#1156) 2018-03-06 09:52:39 -08:00
pubsub_subscription.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
pubsub_topic_iam.html.markdown Add IAM resources for pubsub subscriptions (#1156) 2018-03-06 09:52:39 -08:00
pubsub_topic.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
runtimeconfig_config.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
runtimeconfig_variable.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
sourcerepo_repository.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
spanner_database.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
spanner_instance.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
sql_database_instance.html.markdown add timeouts support for sql database instance (#1288) 2018-04-03 14:44:18 -07:00
sql_database.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
sql_user.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
storage_bucket_acl.html.markdown chore(docs): add undocumented attributes 2017-06-30 12:36:47 +02:00
storage_bucket_iam.html.markdown Fixed small typos in the doc, where the custom roles names should contain "projects|organizations" in plural form. (#1012) 2018-01-26 16:36:57 -08:00
storage_bucket_object.html.markdown Update docs to reflect removal and deprecations. 2017-09-28 15:51:31 -07:00
storage_bucket.html.markdown make it clear that the attribute represents the project id (#672) 2018-03-12 13:59:47 -07:00
storage_default_object_acl.html.markdown Add google_storage_default_object_acl resource (#992) 2018-01-25 11:29:49 -08:00
storage_notification.html.markdown Storage Notification Resource (#1033) 2018-02-05 14:14:36 -08:00
storage_object_acl.html.markdown fixing example of google_storage_object_acl (#642) 2017-11-02 10:50:54 -07:00
usage_export_bucket.html.markdown Add usage export bucket resource. (#1080) 2018-02-13 13:30:17 -08:00