Commit Graph

8 Commits

Author SHA1 Message Date
letic
cf3c406fee Completely remove App Engine region validation list
As requested in :
https://github.com/terraform-providers/terraform-provider-google/pull/3674
2019-05-23 18:24:44 +02:00
2082c859df Update AppEngine locations with latest from documentation :
https://cloud.google.com/appengine/docs/locations
2019-05-21 17:19:21 +02:00
The Magician
226692d3ca Remember to set gcr domain in AppEngine Read. (#3149)
Signed-off-by: Modular Magician <magic-modules@google.com>
2019-03-01 12:03:51 -08:00
The Magician
c605b0bc4b [Terraform]: Apply gofmt -s to all files managed by MM (#2676)
<!-- This change is generated by MagicModules. -->
/cc @rileykarson
2018-12-20 17:22:22 -08:00
Paddy Carver
8f6d256f51 Fix Dana's comments, round two! 2018-10-02 23:41:31 -07:00
Paddy Carver
691ae9986b Adjust for Dana's comments. 2018-10-02 16:34:34 -07:00
Paddy Carver
3ab8e95ef6 Pretend to delete, no error. 2018-10-02 14:15:31 -07:00
Paddy Carver
9ceb644460 Add google_app_engine_application resource.
Deprecate the app_engine sub-block of google_project, and create a
google_app_engine_application resource instead. Also, add some tests for
its behaviour, as well as some documentation for it.

Note that this is largely an implementation of the ideas discussed in
 #2118, except we're not using CustomizeDiff to reject deletions without
our special flag set, because CustomizeDiff apparently doesn't run on
Delete. Who knew? This leaves us rejecting the deletion at apply time,
which is less than ideal, but the only other option I see is to silently
not delete the resource, and that's... not ideal, either.

This also stops the app_engine sub-block on google_project from forcing
new when it's removed, and sets it to computed, so users can safely move
from using the sub-block to using the resource without state surgery or
deleting their entire project. This does mean it's impossible to delete
an App Engine application from a sub-block now, but seeing as that was
the same situation before, and we just papered over it by making the
project recreate itself in that situation, and people Were Not Fans of
that, I'm considering that an acceptable casualty.
2018-10-02 02:59:17 -07:00