7 Commits

Author	SHA1	Message	Date
Paddy Carver	2fc8da91e7	Fix Dana's comments, expand images to self_links. ... Fix Dana's comments, one of which exposed a bug: we weren't actually fixing the diff. Because resolveImage can return multiple formats, and only returns a self_link if a self_link is passed in, it was diffing more often than not against a self_link supplied in the config. We just had a bug in our CustomizeDiff function that concealed this. I added the resolvedImageSelfLink helper function to turn the output from resolveImage into a self_link, which fixes the problem. It also has the knock-on effect of fixing #2067 at the same time, which is nice. I decided to add another function instead of just modifying resolveImage to always return a self_link because I don't want to deal with the backwards compatibility problems of changing how we're storing a bunch of things in state this close to 1.19.0. And honestly, we should probably just be storing the self_link always, _anyways_.	2018-10-02 01:11:03 -07:00
Nathan McKinley	4408183c9f	Suppress diff for ubuntu-minimal-lts as well as ubuntu-lts. (#1870)	2018-08-14 11:24:37 -07:00
Vincent Roseberry	3a65e36cbc	Diff suppress unconventional public image family naming pattern (#1024) ... * DiffSuppress for all public images family names * Update documentation * TF_ACC guard * diskImageEquals should use ==	2018-01-31 09:33:26 -08:00
Stefan Schmidt	bda219f276	Allow for legacy domain-scoped project IDs. (#960)	2018-01-19 15:11:30 -08:00
Vincent Roseberry	bded8d19ec	Better DiffSuppressFunc for disk image field (#884) ... * Proper DiffSuppress for disk image field * Add support for more possible image format	2017-12-21 10:00:35 -08:00
Dana Hoffman	cc8ea81117	Fix a few instances where we read the project from the provider config and not using the helper function (#469)	2017-09-26 17:01:52 -07:00
Jake Champlin	66029ac431	Transfer google provider	2017-06-06 11:58:51 -04:00