* Switch to using golangci-lint instead of gometalinter.
* Update list of allowed ignored errors.
* Add GOFLAG=mod-vendor env var to travis.
* Fix env vars.
This isn't working locally, but it matches the changes made in https://github.com/terraform-providers/terraform-provider-azurerm/pull/2722 so maybe something freaky is going on and it will only work in CI?
Edit: This only works in CI (well, at least doesn't work locally for *me*) but the same is true in the Azure provider. Most of those rules can be turned back on provided we make the corresponding code changes, but let's bring back `unused` for now. I'll dupe over to tpgb on approval.
Adding `.x` to Travis means use the latest minor version according to its docs.
I didn't update the "Requirements" header because this is just because of Go Modules; see https://github.com/terraform-providers/terraform-provider-google/pull/2932 for why. Since it's just a development change, it doesn't impact _using_ the provider.
Although, out of curiosity- is that header for development? Or is there a real requirement to have Go installed to use Terraform providers?
Switch to using Go modules.
This migrates our vendor.json to use Go 1.11's modules system, and
replaces the vendor folder with the output of go mod vendor.
The vendored code should remain basically the same; I believe some
tree shaking of packages and support scripts/licenses/READMEs/etc.
happened.
This also fixes Travis and our Makefile to no longer use govendor.
Parallel to https://github.com/terraform-providers/terraform-provider-azurerm/pull/2116
We need to run `gofmt -s` to switch over to the `gofmt` rule, and MM is going to complicate that. Once `1.20.0` is done, I'll run that command on flat MM files & add a `gofmt -s` step to MM generation (goimports does gofmt but doesn't do the s flag for silly reasons).
I'll duplicate this over to tpgb once this PR is merged.
