Commit Graph

547 Commits

Author SHA1 Message Date
Vincent Roseberry
842256abc2
Return an error if name and name prefix are specified in node pool (#1062) 2018-02-08 13:35:35 -08:00
Vincent Roseberry
476fc5a945
Update master_auth password in cluster datasource test to meet the new minimal length requirement (#1063) 2018-02-08 10:16:51 -08:00
Vincent Roseberry
e8c5266a2f
Mark subnetwork field in container cluster as computed (#1061)
* Mark subnetwork field in container cluster as computed

* make fmt
2018-02-08 10:04:16 -08:00
Dana Hoffman
e48f247196
org policy test fixes (#1059) 2018-02-07 14:55:03 -08:00
Vaidas Jablonskis
1b042a3b18 Cloud SQL user password can be optional (#1056) 2018-02-07 11:59:23 -08:00
ishashchuk
7257b9aaa8 Storage Notification Resource (#1033)
* Storage Default Object ACL resource

* Fixed the doc

* Renamed the resource id. Log change

* Complying with go vet

* Changes for review

* link to default object acl docs in sidebar

* Support for GCS notifications

* docs for storage notification

* docs for storage notification

* Clarified the doc

* Doc modifications

* Addressing requested changes from review

* Addressing requested changes from review

* Using ImportStatePassthrough
2018-02-05 14:14:36 -08:00
Vincent Roseberry
388f9bcd79
Don't set MaxRate and MaxRateInstance (#1053)
* Don't set MaxRate and MaxRateInstance

* Fix if check
2018-02-05 12:58:11 -08:00
Vincent Roseberry
90b9fa1208
Remove master_auth from test that don't need it (#1049) 2018-02-05 11:15:03 -08:00
Emily Ye
41a0fddfbd remove multiple locks from cluster update and add lock helper 2018-02-05 09:45:53 -08:00
Vincent Roseberry
9d59f5f93a
Remove unnecessary Exists methods (#1032)
* Remove unnecessary
exists method

* make fmt

* Remove unused import
2018-02-02 13:04:22 -08:00
Dana Hoffman
cfac1dbc8b
deprecate compute_image.custom_timeout (#1038) 2018-02-02 10:56:18 -08:00
Vincent Roseberry
629c53be03
Make get(Region|Project|Zone) method testable (#1040) 2018-02-02 10:55:43 -08:00
Emily Ye
10ef26a905 actually fix container_network_policy diff suppress and add test 2018-02-01 10:25:12 -08:00
Emily Ye
5f3070e223 add diff suppress for empty network policy in container cluster 2018-01-31 14:36:03 -08:00
Vincent Roseberry
3a65e36cbc
Diff suppress unconventional public image family naming pattern (#1024)
* DiffSuppress for all public images family names

* Update documentation

* TF_ACC guard

* diskImageEquals should use ==
2018-01-31 09:33:26 -08:00
emily
d59f5fc3c1
Merge pull request #1028 from emilymye/capacity_scaler_1014
Force send numeric values if set for compute backend services
2018-01-30 17:13:36 -08:00
Emily Ye
24975fedd2 force send numeric values if set for compute backend services 2018-01-30 17:01:46 -08:00
Vincent Roseberry
559f28016f
Remove unnecessary StateFunc in compute_target_https_proxy (#1027)
* Remove unnecessary StateFunc in https proxy

* Support name only certificates

* Remove test for the removed validate func
2018-01-30 16:07:43 -08:00
emily
db3a88ebef
Merge pull request #1015 from jphalip/route-priority-optional
Make route priority optional, default to 1000
2018-01-30 15:20:03 -08:00
Dana Hoffman
3074db8084
keep description the same between updates 2018-01-30 14:41:20 -08:00
Jeff Johnson
d9a4be0c6c Remove Optional flag from Computed server_ca_cert resource (#1025)
Response to PR comment:
https://github.com/terraform-providers/terraform-provider-google/pull/1020#pullrequestreview-92660096
2018-01-30 14:37:30 -08:00
emily
f73db84c7e
Merge pull request #1019 from ewbankkit/issue-1018
Set 'project' attribute when importing 'google_logging_project_sink'
2018-01-30 13:32:59 -08:00
emily
7e91cbb05d
Merge pull request #1020 from johnsonj/master
Add support for Cloud SQL CA Cert (#635)
2018-01-30 13:19:37 -08:00
Vincent Roseberry
429c8e834c
Remove latest image from diskImageDiffSuppress (#1021) 2018-01-30 11:05:23 -08:00
Kit Ewbank
1f7e84c25e Call 'parseLoggingSinkId' to parse logging project sink ID. 2018-01-29 18:23:08 -05:00
Kit Ewbank
a51117ca97 Add back seperate logging project sink import test. 2018-01-29 18:22:15 -05:00
Jeff Johnson
6e101dd3b7 Add support for Cloud SQL CA Cert (#635)
Expose the 'ServerCaCert' object from the Cloud SQL Instance[1]

Related: #635 - Solves first point

[1] https://cloud.google.com/sql/docs/mysql/admin-api/v1beta4/instances#resource
2018-01-29 13:53:54 -08:00
Kit Ewbank
8748941116 Set 'project' attribute when importing 'google_logging_project_sink'. 2018-01-29 09:19:47 -05:00
Kit Ewbank
31bc09279d
Fix nil pointer dereference updating project labels. 2018-01-27 16:55:39 -05:00
Julien Phalip
261a43e633 Make route priority optional, default to 1000
Fixes #1009
2018-01-27 13:37:32 -08:00
ishashchuk
9f21b56fe5 Add google_storage_default_object_acl resource (#992)
* Storage Default Object ACL resource

* Fixed the doc

* Renamed the resource id. Log change

* Complying with go vet

* Changes for review

* link to default object acl docs in sidebar
2018-01-25 11:29:49 -08:00
Patrick Pelletier
eaac260f36 Add support for setting bucket's logging config (#946)
* Add support for setting bucket's logging config

* Add log_object_prefix and fix nil Logging condition
2018-01-25 11:02:08 -08:00
Nathan McKinley
9d3e64cdaf
Add cloud endpoints resource (#933)
OpenAPI & gRPC Endpoints on Compute Engine.

New Resource:
- Endpoints Service Create/Read/Delete
- Example terraform config
2018-01-24 13:03:57 -08:00
Simon Pizonka
fec2f0bc02 Add support for Google Cloud IoT Core registry (#970) 2018-01-24 13:03:09 -08:00
Dana Hoffman
c18ac00e8f
Add generic http client to Config struct (#994) 2018-01-24 13:00:53 -08:00
Kit Ewbank
b795a4563e Import google_compute_shared_vpc_host_project/google_compute_shared_vpc_service_project resources (#1004)
* Import google_compute_shared_vpc_host_project/google_compute_shared_vpc_service_project resources.

* Incorporate testing of resource import into main acceptance tests.
2018-01-24 12:54:42 -08:00
Dana Hoffman
3b753cefa2
Add update support for machine type, min cpu platform, and service accounts (#1005)
* Add update support for compute instance fields that require the machine to be stopped

* add warnings in docs about stopping the instance before updating

* add allow_stopping_for_update field
2018-01-24 12:50:39 -08:00
Lawrence Jones
9f42aeb652 PostgreSQL high availability (#1001)
* Update sqladmin api

Pull in updates to the generated sqladmin api and update callers for
the change in the StorageAutoResize setting

* Add support for availability_type setting

Allow specifying ZONAL or REGIONAL to allow for PostgreSQL HA
setup.

* vendor: update sqladmin/v1beta4

* Test setting AvailabilityType for PostgreSQL

Add tests that cover the creation of a Postgres database with
AvailabilityType set to REGIONAL, and correct some small issues that
were preventing compilation.

* Fix breaking change w/ disk_autoresize in cloudsql

95e5582766

The cloudsql admin client changed the way it handles StorageAutoResize
as a parameter, in order to be more explicit about when the server has
ommitted the field. This changed the type from being bool to *bool, and
we need to modify provider code so that we supply the right value to the
api client.
2018-01-24 09:23:48 -08:00
Dana Hoffman
33626a1e33
add metadata to gce cluster config in dataproc (#999) 2018-01-23 16:08:51 -08:00
Jacob Straszynski
939ba6d365 skip guest accelerators if count is 0. (#866)
* skip guest accelerators if count is 0.

Instances in instance groups in google will fail to provision, despite
requesting 0 GPUs. This came up for me when trying to provision
a similar instance group in all available regions, but only asking for
GPU's in those that support them by parameterizing the `count` and
setting it to 0.

This might be a violation of some terraform principles. For example,
testing locally with this change `terraform` did not recognize that
indeed my infra needed to be re-deployed (from it's pov, I assume it
believes this because inputs hadn't changed). Additionally, there may be
valid reasons for creating an instance template with 0 gpu's that can be
tuned upwards.

* Add guest accelerator skip test for instances.

* do not leave empty pointers to guest accelerators.

* attempt to clear guest accelerator diff

* conditionally customize diff for guest accels
2018-01-23 11:51:36 -08:00
Nathan McKinley
535fc64a14
condition.IsLive can come back nil - avoid crash if it does. (#997) 2018-01-22 14:14:02 -08:00
Nathan McKinley
0133845a19
Wrap HTTP errors so that concurrent-modification-detection works as designed. (#987) 2018-01-19 16:31:51 -08:00
Nathan McKinley
7b54aa8540
Read project name from API instead of inferring from provider in case of import. (#985) 2018-01-19 15:32:57 -08:00
Stefan Schmidt
bda219f276 Allow for legacy domain-scoped project IDs. (#960) 2018-01-19 15:11:30 -08:00
Vincent Roseberry
3e900a3e6b
Bump up defaults timeout for dataproc (#979) 2018-01-18 11:12:14 -08:00
Vincent Roseberry
5043f60939
Fix canonical image (#978) 2018-01-18 10:49:30 -08:00
Dana Hoffman
92b9984dae
fix gke tests (#977) 2018-01-18 09:51:55 -08:00
Nathan McKinley
d8aea17b19
New simple data sources for GCR Repo and Image. (#954)
New, very simple data sources for GCR Repo and Image, plus docs.
2018-01-17 18:47:25 -08:00
Vincent Roseberry
681cc72f38
Read compute instance boot disk initialization params from API (#948)
* read boot disk initialization param from API

* make fmt

* Mark the initialize_params list as computed to support boot source

* Ensure private family test follow naming pattern

* Improve docs
2018-01-17 13:23:24 -08:00
Vincent Roseberry
c9826b1452
Support subnetwork IP CIDR range expansion (#945)
* Vendor schema/helper/customdiff

* Support subnetwork IP CIDR range expansion

* Change wording
2018-01-17 12:58:37 -08:00
Vincent Roseberry
fc7c0ce74a
Add import support to google_dns_record_set (#895)
* Add import support to google_dns_record_set

* Add import test to NS record

* Minimize diff change

* Improve docs

* Make error message more helpful

* Add note about trailing dot at the end of the record name
2018-01-17 11:19:55 -08:00
Vincent Roseberry
d0f5fec463
Standardize resource name extraction from self_link/uri (#939)
* Standardize resource name extraction from self_link/uri

* remove rebase artifact

* style improvement

* Fix merge issue
2018-01-17 10:45:28 -08:00
Kit Ewbank
34279a6bde Correct usage of 'folders' for 'google_folder_organization_policy' resource. (#963) 2018-01-17 10:26:16 -08:00
Kit Ewbank
233485ba8a Fix 'go vet' error - 'arg found.AutoscalingPolicy.CpuUtilization.UtilizationTarget for printf verb %d of wrong type: float64'. (#969) 2018-01-17 09:52:20 -08:00
Nathan McKinley
719bbb40aa
Fix autoscaler - was unnecessarily forcing to a single metric (#966)
Fix for autoscalers - we were unnecessarily forcing to a single metric when multiple metrics are supported.
2018-01-16 17:10:13 -08:00
Nathan McKinley
ea50226ade
Add disable_on_destroy option to google_project_service. (#965) 2018-01-16 14:39:27 -08:00
James McGill
bc266979d4 Revert "Ensure Elem is always either a *Schema or *Resource (#929)" (#950)
This reverts commit a3352655ac.
2018-01-12 10:09:06 -08:00
Vincent Roseberry
3d178f5633
Fix update when changing health check type (#944) 2018-01-12 10:04:37 -08:00
Nathan McKinley
f50d4a19b4
New Resource: Dataflow Job (#855)
Add support for Google Dataflow jobs

Note: A dataflow job exists when it is in a nonterminal state, and does not exist if it
is in a terminal state (or a non-running state which can only transition into terminal
states).  See doc for more detail.
2018-01-10 14:38:15 -08:00
sarunask
f07c332849 Cloud functions (#899)
* Initial commit

* Adding google_cloudfunction_function resource

* Some FMT updates

* Working Cloud Function Create/Delete/Get
Create is limited to gs:// source now.

* Fixed tests import

* Terraform now is able to apply and destroy function

* Fully working Basic test

* Added:
1. Allowed region check
2. readTimeout helper

* Found better solution for conflicting values

* Adding description

* Adding full basic test

* dded Update functionality

* Made few more optional params

* Added test for Labels

* Added update tests

* Added storage_* members and made function source deploy from storage bucket object

* Adding comments

* Adding tests for PubSub

* Adding tests for Bucket

* Adding Data provider

* Fixing bug which allowed to miss error

* Amending Operation retrieval

* Fixing vet errors and vendoring cloudfunctions/v1

* Fixing according to comments

* Fixing according to comments round #2

* Fixing tabs to space

* Fixing tabs to space and some comments #3

* Re-done update to include labels in one update with others

* Adding back default values. In case of such scenario, when user creates function with some values for "timeout" or "available_memory_mb", and then disables those attributes. Terraform plan then gives:
No changes. Infrastructure is up-to-date.
This is an error. By adding const we would avoid this error.

* Fixed MixedCase and more tabs
2018-01-10 13:25:43 -08:00
Jonathan Pentecost
e3b6e3ea8c google/resource_source_repos_repository: Export repository url (#943)
* google/resource_source_repos_repository: Export repository url

* website/docs/r/sourcerepo_repository: Update official documentation link
2018-01-10 11:26:16 -08:00
Vincent Roseberry
3690926170
Support self_link from different project in dataproc network and subnetwork fields (#935) 2018-01-10 11:05:24 -08:00
Vincent Roseberry
4bd526a4f6
Deprecate the policy_data field of the google_service_account (#942) 2018-01-10 10:44:01 -08:00
Vincent Roseberry
da3a6f13a1
Infers region from zone before using the provider-level region (#938) 2018-01-09 13:57:02 -08:00
Vincent Roseberry
6ba6dfa6d2
Ensures operation on a cluster are applied serially (#937) 2018-01-09 12:39:04 -05:00
Dana Hoffman
585c734503
Set default scopes when creating GKE clusters/node pools (#924)
* set scopes by default

* clarify list -> list/set
2018-01-08 15:54:45 -08:00
Quinn Vallance
5a557546a7 Add google_logging_organization_sink resource (#923)
* Add google_logging_organization_sink resource

* cleanup
2018-01-08 18:15:30 -05:00
Piyush Mishra
de23b59463 Fix a typo in error message (#928) 2018-01-08 12:49:30 -08:00
James McGill
a3352655ac Ensure Elem is always either a *Schema or *Resource (#929)
* Ensure Elem is always either a *Schema or *Resource

* Revert vendor file
2018-01-08 12:48:26 -08:00
Vincent Roseberry
0252501cd4
Don't access attributes on a nil object (#918) 2018-01-04 16:17:03 -05:00
Dana Hoffman
5bf56797f7
make provider-wide region optional (#916) 2018-01-03 14:09:46 -08:00
Vincent Roseberry
dab491d28d
Make zone field consistent and truly optional for all resources (#914) 2018-01-03 16:18:40 -05:00
Vincent Roseberry
52462382c9
Refactor import tests for the remaining compute resources (#909)
* Improve instance group manager import tests

* Improe instance template & project metadata import test

* Improve region autoscaler import test

* Improve router interface import test

* Improve router peer import test

* Improve SSL certs import test

* Improve http & https target proxy import tests

* Improve target pool import test

* Improve url map import test

* Improve target ssl & tcp proxy import test

* Add import test for instance template disk
2018-01-03 09:26:55 -05:00
Vincent Roseberry
999ae08957
Fix flatten IAP and improve import test (#907) 2018-01-02 15:47:28 -05:00
Vincent Roseberry
d9f3e6b249
Add unit test for the self link diff suppress function (#904) 2018-01-02 14:21:04 -05:00
Vincent Roseberry
283c8f89e3
Delete unused methods (#905) 2018-01-02 14:15:13 -05:00
Michael Bannister
18534c9e7d Don't recreate container_cluster when maintenance_window changes (#893)
* Don't recreate container_cluster when maintenance_window changes

Fixes #727

* Omit ForceNew when false

Review comments for PR #893

* Move MaintenancePolicy mapping logic into expand/flatten functions

Review comments for PR #893

* Improve acceptance test for maintenance window update/removal

Review comments for PR #893
2017-12-27 12:29:14 -08:00
Vincent Roseberry
f15d66f28a
Remove noisy log statement (#896)
* Remove noisy log statement

* Remove unused import
2017-12-22 16:49:01 -08:00
Nick Jacques
46cc5b7d84 WIP: Add "internal IP only" support for Dataproc clusters (#837)
* Add internalIpOnly support for Dataproc clusters

* Add internal_ip_only to dataproc cluster docs

* Add default/basic dataproc internal ip test case

* Add test for dataproc internal_ip_only=true

* fixup cluster_config.gce_cluster_config to include .0.

* Remove redundant depends_on

* Add %s rnd to network and subnetwork

* Use variable for subnet CIDR and reference via source_ranges

* Add depends_on back to dataproc cluster test

* Fix cluster attribute refs (.0. again)
2017-12-22 13:24:05 -08:00
Kit Ewbank
49a0008643 Add 'google_organization' data source (#887)
* Add 'google_organization' data source.

* Use 'GetResourceNameFromSelfLink'.

* Remove 'resourcemanager_helpers'.

* Use 'ConflictsWith' in schema.

* Add 'organization' argument and make 'name' an output-only attribute.
2017-12-21 16:12:44 -08:00
Kit Ewbank
a086e70e79 Add 'google_billing_account' data source (#889)
* Add 'google_billing_account' data source.

* Use 'GetResourceNameFromSelfLink'.

* Use 'ConflictsWith' in schema.

* Use pagination for List() API call.

* Add ability to filter by 'open' attribute.

* Don't use 'ForceNew' for data sources.

* Add 'billing_account' argument and make 'name' an output-only attribute.

* Correct error message.
2017-12-21 16:09:58 -08:00
Vincent Roseberry
bded8d19ec
Better DiffSuppressFunc for disk image field (#884)
* Proper DiffSuppress for disk image field

* Add support for more possible image format
2017-12-21 10:00:35 -08:00
Dana Hoffman
f9f35bbe4a
more descriptive error message for health check not found (#883) 2017-12-20 13:22:48 -08:00
Matt Morrison
23ef50f5ca New datasource: google_container_cluster (#740)
* Add google_kubernetes_cluster datasource

Add documentation for google_kubernetes_cluster datasource

Rename datasource to google_container_cluster

To be consistent with the equivalent resource.

Rename datasource in docs.
google_kubernetes_cluster -> google_container_cluster.
Also add reference in google.erb file.

WIP

Datasource read needs to set an ID, then call resource read func

Add additional cluster attributes to datasource schema

* Generate datasource schema from resource

Datasource documentation also updated.

* add test for datasourceSchemaFromResourceSchema

* Code review changes
2017-12-20 13:21:11 -08:00
Vincent Roseberry
742462f9a6
Properly handle firewall direction field (#885) 2017-12-20 13:14:33 -08:00
Vincent Roseberry
502456a35d
Rename filename to match resource (#882)
* Rename filename to match resource

* Rename tests method
2017-12-20 10:48:43 -08:00
Vincent Roseberry
42cc44efe2
Add IAM support for pubsub topic (#875)
* Add IAM support for pubsub topic

* Fix resource name

* Add update test for iam_policy resource

* Standardize policy conversion function

* Standardize policy conversion function all resources
2017-12-19 17:19:04 -08:00
Vincent Roseberry
140440947a
Refactor some more import tests (#881) 2017-12-19 15:33:20 -08:00
Vincent Roseberry
b82949bdcd
Reduce number of new project creation (#880) 2017-12-19 14:40:24 -08:00
Vincent Roseberry
c1d9bb24c9
Support import in compute instance (#873) 2017-12-19 14:33:30 -08:00
Michael Parker
18a6255064 Adds google_kms_secret data source (#741)
* Create google_kms_secret datasource

* Create google_kms_secret datasource documentation

* Remove duplicated code

* Create acceptance test

* Fix indentation

* Add documentation to sidebar

* Update Cloud SDK link in docs

* Oxford comma

* Rename variable to make it clear which resource is under test

* Update test to use utils from provider_test
2017-12-19 13:24:35 -08:00
Vincent Roseberry
2e9933be44
Ignore beta vs v1 network diff in subnetwork datasource test (#849) 2017-12-19 13:08:14 -08:00
Vincent Roseberry
bc03e98998
Merge import test in regular acceptance tests for a few compute resources (#874) 2017-12-19 12:43:30 -08:00
Jonathan Liuti
e3bd6b9a1d Add configurable timeouts to subnetworks (#871) 2017-12-18 09:47:11 -08:00
Vincent Roseberry
b70803264f
Add service account IAM support (#840)
* Add service account iam resources
* Add documentation
* Add import functionality to iam resources
* Add import documentation
2017-12-14 14:52:44 -08:00
Vincent Roseberry
293728929f
Add update support for routing mode in google_compute_network (#857)
* Fetch latest compute v1 client

* Add update support for rounting in google_compute_network
2017-12-14 14:28:58 -08:00
Nathan McKinley
d2611d4ce3
New data source: compute region instance group (#851)
* Add new data source: compute region instance group manager's groups.
* Add documentation for wait_for_instances and for the timeout mechanism in resourceComputeRegionInstanceGroupManagerCreate.
2017-12-14 13:35:39 -08:00
Vincent Roseberry
d2289c2ca1
Add configurable timeouts to google_compute_instance (#856) 2017-12-13 17:03:15 -08:00
Vincent Roseberry
433fdcc49f
Storage bucket doesn't remove lifecycle rules properly (#850)
* Update storage client

* Read lifecycle from API and improve acceptance tests
2017-12-13 16:46:48 -08:00
Vincent Roseberry
5585b14069
Import test refactoring for some resources. (#854)
* Improve import tests for folder, org iam custom roles and org policies

* improve import test for google project
2017-12-13 16:45:52 -08:00