Commit Graph

603 Commits

Author SHA1 Message Date
Dana Hoffman
fd0819786b
revive initial_node_count (#1176) 2018-03-13 11:45:01 -07:00
Benjamin Pineau
f65127585a Datasource for Backend Services (#1150)
Exposes existing `google_compute_backend_service` as data sources.
This addresses #149 .

This allows, for instance, to collect a backend service's self_link and
use it from an other workspace/tfstate, sharing most of the
loadbalancers definition.
2018-03-12 15:09:30 -07:00
ssaqua
9155a556ef Update to Cloud Functions Pub/Sub trigger event (#1180) 2018-03-12 14:55:55 -07:00
Dana Hoffman
9ae7a8ddb0
test fixes (#1185) 2018-03-12 13:18:39 -07:00
ishashchuk
2efa710696 Datasource for GCE service account (#1119)
* Data source for retrieving GCE service account
* Added project id for service account lookups (#15)
* Renaming attribute project_id -> project
2018-03-12 09:41:15 -07:00
Dana Hoffman
c33b33e1cc
expect 4 labels in dataproc cluster test (#1182) 2018-03-12 09:06:05 -07:00
Dana Hoffman
edf8918db6
Add generated resources for http(s)_health_check, updates to backend_bucket, and import helpers (#1177)
* add import helpers for generated code

* Updates to backend bucket and transport.go from MM

* add generated http(s)_health_check resources

* name is required; transport import style

* update docs with new fields/timeouts

* fixes
2018-03-09 17:14:32 -08:00
Toby Lawrence
08e81f528c Support distributionPolicy when creating regional instance group managers. (#1092)
* Support `distributionPolicy` when creating regional instance group managers.

* Better match the API structure of distributionPolicy.

* Switch to "distribution_policy_zones".

This approach lets us more simply allow a list of zones to use, while
providing a deprecation path for implementing the distribution policy
field more holistically, avoiding backwards-incompatible changes.

* fix typo

* use slice instead of Set for flattenDP
2018-03-09 11:04:09 -08:00
Dana Hoffman
1d1cfa64c4
increase timeout for dataproc test jobs completing (#1172) 2018-03-08 19:24:57 -08:00
Dana Hoffman
ab385ff574
don't set omitted fields when converting between a map and a struct (#1165) 2018-03-08 10:51:25 -08:00
Dana Hoffman
fc58b8e54c
Fix typo in pubsub iam test (#1169) 2018-03-08 09:16:50 -08:00
Dana Hoffman
46fb949c1f
Set ID for GKE resources before waiting (#1158) 2018-03-07 11:06:00 -08:00
Dana Hoffman
6d8a8b1747
Add more beta scaffolding for GKE resources (#1139)
* vendor container/v1beta1

* revendor container/v1beta1

* add beta scaffolding for gke resources

* fix json unmarshal error

* fix issues with trying to convert interface instead of struct

* same fixes but for node pool

* move setid calls back
2018-03-06 17:44:05 -08:00
Vincent Roseberry
91c9e0851c
Add IAM resources for pubsub subscriptions (#1156)
* Add IAM resources for pubsub subscription

* Add documentation

* Refactored topic and subscription computed methods

* Add project field to documentation

* Addressed Dana's comments
2018-03-06 09:52:39 -08:00
Paddy
9f47852189
Merge pull request #1141 from terraform-providers/paddy_863
Fix perpetual diff in #863.
2018-03-05 16:40:26 -08:00
Vincent Roseberry
35c2cb2abf
Add project field to iam pubsub topic resources (#1154)
* Add project field to iam pubsub topic resources

* Update documentation
2018-03-05 15:31:24 -08:00
Julien Phalip
3e4b66884b Let the compute zones data source accept a project parameter (#1122) 2018-03-05 13:32:14 -08:00
Florian Pfeiffer
6a2fca86a0 Loosen regex on projectId for importSpannerInstanceId and importSpannerDatabaseId (#1151) 2018-03-05 13:24:55 -08:00
Nathan McKinley
e8ffe89817
Extra error handling for node pools that don't match instance manager pattern. (#1149) 2018-03-02 17:14:48 -08:00
Florian Pfeiffer
5ea98d27f9 Loosen regex in computeDiskUserRegexString - accept ":" or "." (#1145) 2018-03-02 12:10:40 -08:00
Dana Hoffman
1d64cc5d26
allow importing a pubsub topic using its full id (#1142) 2018-03-02 11:22:58 -08:00
Dana Hoffman
263240dd9f
fix typos in pyspark dataproc job resource (#1120) 2018-03-01 18:02:33 -08:00
Genevieve
7e358d894a SQL DB Instance has attribute first_ip_address (#1050)
* Expose first ip address on sql db instance.

Signed-off-by: Desmond Pompa Alarcon Rawls <captaingrover@gmail.com>

* Use the ip_address key on the first map in ip_address list.

Signed-off-by: Genevieve LEsperance <glesperance@pivotal.io>

* Run first_ip_address test check if there is an ip address.

Signed-off-by: Desmond Pompa Alarcon Rawls <captaingrover@gmail.com>

* Add first_ip_address to sql db instance scheme.

Signed-off-by: Genevieve LEsperance <glesperance@pivotal.io>
2018-03-01 17:12:33 -08:00
Nathan McKinley
58a7ef9d03
Fix incorrect result on Read ignoring most authorized networks. (#1097) 2018-03-01 13:19:18 -08:00
Paddy Carver
61c1eb2719 Make RRdatas case insensitive.
The GCP backend apparently lowercases the values, no matter what you
enter, so we consider uppercase and lowercase values to be equivalent.
This fixes #862.
2018-03-01 13:01:30 -08:00
Paddy Carver
391516d741 Fix perpetual diff in #863.
This treats record set RRdata values as equivalent if they're quoted and
unquoted, as the GCP backend likes to return TXT records quoted.
2018-03-01 12:50:47 -08:00
ishashchuk
67ecf5345e Data source for retrieving project information (#1111)
* Project data source

* Mirroring project datasource from project resource (#14)
2018-02-28 12:37:24 -08:00
Dana Hoffman
313eb0fb89
Check set equality for service account scope changes (#1130)
* add debug printfs

* more logs for debugging

* check set equality for service acct scope changes

* revert changes to region igm

* style things
2018-02-27 14:29:00 -08:00
Dana Hoffman
919e7ee52f
Don't store disk id in state if it didn't create (#1129) 2018-02-26 11:13:20 -08:00
Darren Hague
5b0d8d43ff Allow specifying accelerators in cluster node_config (#1115) 2018-02-23 16:55:07 -08:00
Dana Hoffman
6d0b87ec1e
s/TestAccGoogle/TestAcc/ (#1121)
* s/TestAccGoogle/TestAcc/

* add back import

* reorder imports
2018-02-23 15:14:24 -08:00
Nathan McKinley
640e25931e
Move log statement for storage bucket (#1126) 2018-02-23 10:58:42 -08:00
Nathan McKinley
151e83aa26
Only check project if it's not present on the resource. (#1125) 2018-02-22 15:31:55 -08:00
Dana Hoffman
4154db93e9
add diffsuppress to allow lowercase ip protocols (#1118) 2018-02-22 09:27:43 -08:00
Dana Hoffman
9a4c92bb1b
add json omitted fields back when converting (#1098)
* add json omitted fields back when converting

* for testing: don't use json in convert

* try a combination of structs and mapstructure libraries

* Revert "try a combination of structs and mapstructure libraries"

This reverts commit eab11aa95d3abb74b240988e5c99d6e9525db96c.

* Revert "for testing: don't use json in convert"

This reverts commit 96af067b29dd147fcedb55995ebc8a17c6a9d1b2.
2018-02-22 09:27:02 -08:00
ishashchuk
ef3ea881b1 Datasource for retrieving GCS service account (#1110)
* Datasource for retrieving GCS service account

* Removing duplicated argument

* Gofmt post resolving conflicts

* Addressing review comment
2018-02-21 13:37:23 -08:00
Vincent Roseberry
304c0aa6cb
Move method out of resource file to prepare for autogen (#1102) 2018-02-20 12:40:02 -08:00
Vincent Roseberry
297b0a80e0
Refactor PubSub import test (#1106)
* Refactor pubsub subscription import test

* Refactor pubsub topic import test
2018-02-20 11:12:22 -08:00
Konstantinos Tsanaktsidis
411017c35f Fix overly restrictive validation for ServiceAccountLinkRegex (#1073) 2018-02-20 10:36:18 -08:00
Nathan McKinley
026e813287
Run gofmt. (#1095) 2018-02-15 19:26:36 -08:00
Vincent Roseberry
21564c36a1
Move method from resource to datasource file (#1093) 2018-02-15 15:40:40 -08:00
Dana Hoffman
7977d277ec
Add scaffolding to enable beta features in GKE resources (#1085)
* make api_versions more generic

* add api versions for gke
2018-02-15 18:37:36 -05:00
Vincent Roseberry
4b1fdee504
Changes to handle autogeneration. (#1087)
* Add Set method to TerraformResourceData and ResourceDataMock

* Add Id() and SetId() to ResourceDataMock and TerraformResourceData

* Keep only name when reading region or zone field to handle api that returns self_link
2018-02-15 15:32:31 -08:00
Julien Phalip
7477c7482c Let route resource accept "description" attribute (#1088) 2018-02-15 13:03:28 -08:00
Julien Phalip
c607b466f6 Fix VPN gateway data source schema for "network" attribute. (#1086) 2018-02-14 16:16:42 -08:00
Dana Hoffman
2e665f2f35
add support for updating alias ips in instances (#1084) 2018-02-14 15:48:47 -05:00
Nathan McKinley
f7851162a4
Don't set metadata_startup_script in some cases. (#1081) 2018-02-13 23:55:37 -08:00
Julien Phalip
1966a791a6 Add data source for forwarding rule (#1078) 2018-02-13 17:43:08 -08:00
Nathan McKinley
8354a43d1a
Add usage export bucket resource. (#1080) 2018-02-13 13:30:17 -08:00
Kit Ewbank
21e0075f6f Add 'google_folder_iam_binding' and 'google_folder_iam_member' resources (#1076) 2018-02-13 12:49:51 -08:00
Julien Phalip
509614e404 Improve error handling for data sources not found (#1077) 2018-02-13 11:19:59 -08:00
Julien Phalip
f6c5f01a95 Add VPN gateway data source (#1071) 2018-02-12 15:28:02 -08:00
Chase
e1323489ba Feature: select compute instance attached disk mode (#947) 2018-02-12 10:56:06 -08:00
Vincent Roseberry
5f32d7e87a
Fix TestAccContainerCluster_withIPAllocationPolicy test (#1065)
* Remove bad test in testAccContainerCluster_withIPAllocationPolicy

One step was expecting the test to fail if the subnetwork defines
secondary ip ranges that the cluster doesn't use. However, it is
perfectly fine to do so and we don't expect an error.

* Revert "Remove bad test in testAccContainerCluster_withIPAllocationPolicy"

This reverts commit af2f369907181a107cfc0ed9fa2ff0e288f02f66.

* Fail if use_ip_aliases is true and no range names is provided

* make fmt

* don't introduce new field for now. Wait until we want to support new feature in allocation policy
2018-02-09 13:55:38 -08:00
Vincent Roseberry
b789d7c2a0
Support multiple users with the same name for different host for 1st gen. (#1066)
* Support multiple users with the same name for different host for 1st gen.

* Fix typo and rename user
2018-02-09 13:43:49 -08:00
Dana Hoffman
9900e6a4c7
Add generated BackendBucket resource + transport.go (#1064)
* Add generated BackendBucket resource

* add ForceNew back to name

* Add log statements back
2018-02-08 17:58:20 -08:00
Vincent Roseberry
842256abc2
Return an error if name and name prefix are specified in node pool (#1062) 2018-02-08 13:35:35 -08:00
Vincent Roseberry
476fc5a945
Update master_auth password in cluster datasource test to meet the new minimal length requirement (#1063) 2018-02-08 10:16:51 -08:00
Vincent Roseberry
e8c5266a2f
Mark subnetwork field in container cluster as computed (#1061)
* Mark subnetwork field in container cluster as computed

* make fmt
2018-02-08 10:04:16 -08:00
Dana Hoffman
e48f247196
org policy test fixes (#1059) 2018-02-07 14:55:03 -08:00
Vaidas Jablonskis
1b042a3b18 Cloud SQL user password can be optional (#1056) 2018-02-07 11:59:23 -08:00
ishashchuk
7257b9aaa8 Storage Notification Resource (#1033)
* Storage Default Object ACL resource

* Fixed the doc

* Renamed the resource id. Log change

* Complying with go vet

* Changes for review

* link to default object acl docs in sidebar

* Support for GCS notifications

* docs for storage notification

* docs for storage notification

* Clarified the doc

* Doc modifications

* Addressing requested changes from review

* Addressing requested changes from review

* Using ImportStatePassthrough
2018-02-05 14:14:36 -08:00
Vincent Roseberry
388f9bcd79
Don't set MaxRate and MaxRateInstance (#1053)
* Don't set MaxRate and MaxRateInstance

* Fix if check
2018-02-05 12:58:11 -08:00
Vincent Roseberry
90b9fa1208
Remove master_auth from test that don't need it (#1049) 2018-02-05 11:15:03 -08:00
Emily Ye
41a0fddfbd remove multiple locks from cluster update and add lock helper 2018-02-05 09:45:53 -08:00
Vincent Roseberry
9d59f5f93a
Remove unnecessary Exists methods (#1032)
* Remove unnecessary
exists method

* make fmt

* Remove unused import
2018-02-02 13:04:22 -08:00
Dana Hoffman
cfac1dbc8b
deprecate compute_image.custom_timeout (#1038) 2018-02-02 10:56:18 -08:00
Vincent Roseberry
629c53be03
Make get(Region|Project|Zone) method testable (#1040) 2018-02-02 10:55:43 -08:00
Emily Ye
10ef26a905 actually fix container_network_policy diff suppress and add test 2018-02-01 10:25:12 -08:00
Emily Ye
5f3070e223 add diff suppress for empty network policy in container cluster 2018-01-31 14:36:03 -08:00
Vincent Roseberry
3a65e36cbc
Diff suppress unconventional public image family naming pattern (#1024)
* DiffSuppress for all public images family names

* Update documentation

* TF_ACC guard

* diskImageEquals should use ==
2018-01-31 09:33:26 -08:00
emily
d59f5fc3c1
Merge pull request #1028 from emilymye/capacity_scaler_1014
Force send numeric values if set for compute backend services
2018-01-30 17:13:36 -08:00
Emily Ye
24975fedd2 force send numeric values if set for compute backend services 2018-01-30 17:01:46 -08:00
Vincent Roseberry
559f28016f
Remove unnecessary StateFunc in compute_target_https_proxy (#1027)
* Remove unnecessary StateFunc in https proxy

* Support name only certificates

* Remove test for the removed validate func
2018-01-30 16:07:43 -08:00
emily
db3a88ebef
Merge pull request #1015 from jphalip/route-priority-optional
Make route priority optional, default to 1000
2018-01-30 15:20:03 -08:00
Dana Hoffman
3074db8084
keep description the same between updates 2018-01-30 14:41:20 -08:00
Jeff Johnson
d9a4be0c6c Remove Optional flag from Computed server_ca_cert resource (#1025)
Response to PR comment:
https://github.com/terraform-providers/terraform-provider-google/pull/1020#pullrequestreview-92660096
2018-01-30 14:37:30 -08:00
emily
f73db84c7e
Merge pull request #1019 from ewbankkit/issue-1018
Set 'project' attribute when importing 'google_logging_project_sink'
2018-01-30 13:32:59 -08:00
emily
7e91cbb05d
Merge pull request #1020 from johnsonj/master
Add support for Cloud SQL CA Cert (#635)
2018-01-30 13:19:37 -08:00
Vincent Roseberry
429c8e834c
Remove latest image from diskImageDiffSuppress (#1021) 2018-01-30 11:05:23 -08:00
Kit Ewbank
1f7e84c25e Call 'parseLoggingSinkId' to parse logging project sink ID. 2018-01-29 18:23:08 -05:00
Kit Ewbank
a51117ca97 Add back seperate logging project sink import test. 2018-01-29 18:22:15 -05:00
Jeff Johnson
6e101dd3b7 Add support for Cloud SQL CA Cert (#635)
Expose the 'ServerCaCert' object from the Cloud SQL Instance[1]

Related: #635 - Solves first point

[1] https://cloud.google.com/sql/docs/mysql/admin-api/v1beta4/instances#resource
2018-01-29 13:53:54 -08:00
Kit Ewbank
8748941116 Set 'project' attribute when importing 'google_logging_project_sink'. 2018-01-29 09:19:47 -05:00
Kit Ewbank
31bc09279d
Fix nil pointer dereference updating project labels. 2018-01-27 16:55:39 -05:00
Julien Phalip
261a43e633 Make route priority optional, default to 1000
Fixes #1009
2018-01-27 13:37:32 -08:00
ishashchuk
9f21b56fe5 Add google_storage_default_object_acl resource (#992)
* Storage Default Object ACL resource

* Fixed the doc

* Renamed the resource id. Log change

* Complying with go vet

* Changes for review

* link to default object acl docs in sidebar
2018-01-25 11:29:49 -08:00
Patrick Pelletier
eaac260f36 Add support for setting bucket's logging config (#946)
* Add support for setting bucket's logging config

* Add log_object_prefix and fix nil Logging condition
2018-01-25 11:02:08 -08:00
Nathan McKinley
9d3e64cdaf
Add cloud endpoints resource (#933)
OpenAPI & gRPC Endpoints on Compute Engine.

New Resource:
- Endpoints Service Create/Read/Delete
- Example terraform config
2018-01-24 13:03:57 -08:00
Simon Pizonka
fec2f0bc02 Add support for Google Cloud IoT Core registry (#970) 2018-01-24 13:03:09 -08:00
Dana Hoffman
c18ac00e8f
Add generic http client to Config struct (#994) 2018-01-24 13:00:53 -08:00
Kit Ewbank
b795a4563e Import google_compute_shared_vpc_host_project/google_compute_shared_vpc_service_project resources (#1004)
* Import google_compute_shared_vpc_host_project/google_compute_shared_vpc_service_project resources.

* Incorporate testing of resource import into main acceptance tests.
2018-01-24 12:54:42 -08:00
Dana Hoffman
3b753cefa2
Add update support for machine type, min cpu platform, and service accounts (#1005)
* Add update support for compute instance fields that require the machine to be stopped

* add warnings in docs about stopping the instance before updating

* add allow_stopping_for_update field
2018-01-24 12:50:39 -08:00
Lawrence Jones
9f42aeb652 PostgreSQL high availability (#1001)
* Update sqladmin api

Pull in updates to the generated sqladmin api and update callers for
the change in the StorageAutoResize setting

* Add support for availability_type setting

Allow specifying ZONAL or REGIONAL to allow for PostgreSQL HA
setup.

* vendor: update sqladmin/v1beta4

* Test setting AvailabilityType for PostgreSQL

Add tests that cover the creation of a Postgres database with
AvailabilityType set to REGIONAL, and correct some small issues that
were preventing compilation.

* Fix breaking change w/ disk_autoresize in cloudsql

95e5582766

The cloudsql admin client changed the way it handles StorageAutoResize
as a parameter, in order to be more explicit about when the server has
ommitted the field. This changed the type from being bool to *bool, and
we need to modify provider code so that we supply the right value to the
api client.
2018-01-24 09:23:48 -08:00
Dana Hoffman
33626a1e33
add metadata to gce cluster config in dataproc (#999) 2018-01-23 16:08:51 -08:00
Jacob Straszynski
939ba6d365 skip guest accelerators if count is 0. (#866)
* skip guest accelerators if count is 0.

Instances in instance groups in google will fail to provision, despite
requesting 0 GPUs. This came up for me when trying to provision
a similar instance group in all available regions, but only asking for
GPU's in those that support them by parameterizing the `count` and
setting it to 0.

This might be a violation of some terraform principles. For example,
testing locally with this change `terraform` did not recognize that
indeed my infra needed to be re-deployed (from it's pov, I assume it
believes this because inputs hadn't changed). Additionally, there may be
valid reasons for creating an instance template with 0 gpu's that can be
tuned upwards.

* Add guest accelerator skip test for instances.

* do not leave empty pointers to guest accelerators.

* attempt to clear guest accelerator diff

* conditionally customize diff for guest accels
2018-01-23 11:51:36 -08:00
Nathan McKinley
535fc64a14
condition.IsLive can come back nil - avoid crash if it does. (#997) 2018-01-22 14:14:02 -08:00
Nathan McKinley
0133845a19
Wrap HTTP errors so that concurrent-modification-detection works as designed. (#987) 2018-01-19 16:31:51 -08:00
Nathan McKinley
7b54aa8540
Read project name from API instead of inferring from provider in case of import. (#985) 2018-01-19 15:32:57 -08:00
Stefan Schmidt
bda219f276 Allow for legacy domain-scoped project IDs. (#960) 2018-01-19 15:11:30 -08:00