From dcde015f84e6c6070d303cbc7713c0144b8d5dfe Mon Sep 17 00:00:00 2001 From: emily Date: Fri, 14 Sep 2018 14:04:48 -0700 Subject: [PATCH] just make sweeper warn instead of error (#2057) --- google/resource_composer_environment_test.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/google/resource_composer_environment_test.go b/google/resource_composer_environment_test.go index d70db322..ccfdaa42 100644 --- a/google/resource_composer_environment_test.go +++ b/google/resource_composer_environment_test.go @@ -324,6 +324,8 @@ resource "google_composer_environment" "test" { /** * CLEAN UP HELPER FUNCTIONS + * Because the environments are flaky and bucket deletion rates can be + * rate-limited, for now just warn instead of returning actual errors. */ func testSweepComposerResources(region string) error { config, err := sharedConfigForRegion(region) @@ -338,12 +340,12 @@ func testSweepComposerResources(region string) error { // Environments need to be cleaned up because the service is flaky. if err := testSweepComposerEnvironments(config); err != nil { - return err + log.Printf("[WARNING] unable to clean up all environments: %s", err) } // Buckets need to be cleaned up because they just don't get deleted on purpose. if err := testSweepComposerEnvironmentBuckets(config); err != nil { - return err + log.Printf("[WARNING] unable to clean up all environment storage buckets: %s", err) } return nil