From c2dc0479a7ae290116ec5682733cee61a5c09e8d Mon Sep 17 00:00:00 2001 From: James Nugent Date: Mon, 22 Aug 2016 19:27:36 +0200 Subject: [PATCH] provider/google: Remove redundant type declaration This commit cleans up the google_compute_firewall resource to the Go 1.5+ style of not requiring map values to declare their type if they can be inferred. --- resource_compute_firewall.go | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/resource_compute_firewall.go b/resource_compute_firewall.go index 6cc8409d..a47da557 100644 --- a/resource_compute_firewall.go +++ b/resource_compute_firewall.go @@ -26,29 +26,29 @@ func resourceComputeFirewall() *schema.Resource { MigrateState: resourceComputeFirewallMigrateState, Schema: map[string]*schema.Schema{ - "name": &schema.Schema{ + "name": { Type: schema.TypeString, Required: true, ForceNew: true, }, - "network": &schema.Schema{ + "network": { Type: schema.TypeString, Required: true, ForceNew: true, }, - "allow": &schema.Schema{ + "allow": { Type: schema.TypeSet, Required: true, Elem: &schema.Resource{ Schema: map[string]*schema.Schema{ - "protocol": &schema.Schema{ + "protocol": { Type: schema.TypeString, Required: true, }, - "ports": &schema.Schema{ + "ports": { Type: schema.TypeList, Optional: true, Elem: &schema.Schema{Type: schema.TypeString}, @@ -58,38 +58,38 @@ func resourceComputeFirewall() *schema.Resource { Set: resourceComputeFirewallAllowHash, }, - "description": &schema.Schema{ + "description": { Type: schema.TypeString, Optional: true, }, - "project": &schema.Schema{ + "project": { Type: schema.TypeString, Optional: true, ForceNew: true, Computed: true, }, - "self_link": &schema.Schema{ + "self_link": { Type: schema.TypeString, Computed: true, }, - "source_ranges": &schema.Schema{ + "source_ranges": { Type: schema.TypeSet, Optional: true, Elem: &schema.Schema{Type: schema.TypeString}, Set: schema.HashString, }, - "source_tags": &schema.Schema{ + "source_tags": { Type: schema.TypeSet, Optional: true, Elem: &schema.Schema{Type: schema.TypeString}, Set: schema.HashString, }, - "target_tags": &schema.Schema{ + "target_tags": { Type: schema.TypeSet, Optional: true, Elem: &schema.Schema{Type: schema.TypeString},