From 54bff0e3b5824523e272cf9c32d82d6e71ba78d3 Mon Sep 17 00:00:00 2001 From: Dainis Tillers Date: Wed, 8 Apr 2015 14:21:39 +0300 Subject: [PATCH 1/2] Added - create disk from snapshot --- resource_compute_disk.go | 30 +++++++++++++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/resource_compute_disk.go b/resource_compute_disk.go index 56b7ed25..7202e45d 100644 --- a/resource_compute_disk.go +++ b/resource_compute_disk.go @@ -47,6 +47,12 @@ func resourceComputeDisk() *schema.Resource { ForceNew: true, }, + "snapshot": &schema.Schema{ + Type: schema.TypeString, + Optional: true, + ForceNew: true, + }, + "self_link": &schema.Schema{ Type: schema.TypeString, Computed: true, @@ -98,6 +104,21 @@ func resourceComputeDiskCreate(d *schema.ResourceData, meta interface{}) error { disk.Type = diskType.SelfLink } + if v, ok := d.GetOk("snapshot"); ok { + snapshotName := v.(string) + log.Printf("[DEBUG] Loading snapshot: %s", snapshotName) + snapshotData, err := config.clientCompute.Snapshots.Get( + config.Project, snapshotName).Do() + + if err != nil { + return fmt.Errorf( + "Error loading snapshot '%s': %s", + snapshotName, err) + } + + disk.SourceSnapshot = snapshotData.SelfLink + } + op, err := config.clientCompute.Disks.Insert( config.Project, d.Get("zone").(string), disk).Do() if err != nil { @@ -116,7 +137,14 @@ func resourceComputeDiskCreate(d *schema.ResourceData, meta interface{}) error { Type: OperationWaitZone, } state := w.Conf() - state.Timeout = 2 * time.Minute + + if disk.SourceSnapshot != "" { + //creating disk from snapshot takes some time + state.Timeout = 10 * time.Minute + } else { + state.Timeout = 2 * time.Minute + } + state.MinTimeout = 1 * time.Second opRaw, err := state.WaitForState() if err != nil { From c3317e3560631212e6f78f501ee111839dbb7575 Mon Sep 17 00:00:00 2001 From: Dainis Tillers Date: Thu, 16 Oct 2014 16:43:52 +0300 Subject: [PATCH 2/2] Added - disk device name --- resource_compute_instance.go | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/resource_compute_instance.go b/resource_compute_instance.go index d89e82a4..5b49a4b7 100644 --- a/resource_compute_instance.go +++ b/resource_compute_instance.go @@ -81,6 +81,11 @@ func resourceComputeInstance() *schema.Resource { Optional: true, ForceNew: true, }, + + "device_name": &schema.Schema{ + Type: schema.TypeString, + Optional: true, + }, }, }, }, @@ -339,6 +344,10 @@ func resourceComputeInstanceCreate(d *schema.ResourceData, meta interface{}) err disk.InitializeParams.DiskSizeGb = int64(diskSizeGb) } + if v, ok := d.GetOk(prefix + ".device_name"); ok { + disk.DeviceName = v.(string) + } + disks = append(disks, &disk) }