From a42d59b2c5d26cfe169c6a63c10f4504d4ae5f98 Mon Sep 17 00:00:00 2001 From: Vincent Roseberry Date: Mon, 11 Sep 2017 12:43:44 -0700 Subject: [PATCH] Use common utils method in iam policy data source (#405) --- google/data_source_google_iam_policy.go | 15 +-------------- google/data_source_google_iam_policy_test.go | 1 + 2 files changed, 2 insertions(+), 14 deletions(-) create mode 100644 google/data_source_google_iam_policy_test.go diff --git a/google/data_source_google_iam_policy.go b/google/data_source_google_iam_policy.go index e47b0f00..d917c42f 100644 --- a/google/data_source_google_iam_policy.go +++ b/google/data_source_google_iam_policy.go @@ -71,7 +71,7 @@ func dataSourceGoogleIamPolicyRead(d *schema.ResourceData, meta interface{}) err binding := v.(map[string]interface{}) policy.Bindings[i] = &cloudresourcemanager.Binding{ Role: binding["role"].(string), - Members: dataSourceGoogleIamPolicyMembers(binding["members"].(*schema.Set)), + Members: convertStringSet(binding["members"].(*schema.Set)), } } @@ -88,16 +88,3 @@ func dataSourceGoogleIamPolicyRead(d *schema.ResourceData, meta interface{}) err return nil } - -// dataSourceGoogleIamPolicyMembers converts a set of members in a binding -// (a member is a principal, usually an e-mail address) into an array of -// string. -func dataSourceGoogleIamPolicyMembers(d *schema.Set) []string { - var members []string - members = make([]string, d.Len()) - - for i, v := range d.List() { - members[i] = v.(string) - } - return members -} diff --git a/google/data_source_google_iam_policy_test.go b/google/data_source_google_iam_policy_test.go new file mode 100644 index 00000000..71664db3 --- /dev/null +++ b/google/data_source_google_iam_policy_test.go @@ -0,0 +1 @@ +package google