From 9bebdd02f5ecd5037280956e3adc1240ac22f9db Mon Sep 17 00:00:00 2001 From: Vincent Roseberry Date: Wed, 6 Dec 2017 12:36:00 -0800 Subject: [PATCH] Make network name unique between each test run (#826) * Make network name unique between each test run * make fmt --- google/data_source_google_compute_subnetwork_test.go | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/google/data_source_google_compute_subnetwork_test.go b/google/data_source_google_compute_subnetwork_test.go index 6dcf3089..219a8070 100644 --- a/google/data_source_google_compute_subnetwork_test.go +++ b/google/data_source_google_compute_subnetwork_test.go @@ -4,6 +4,7 @@ import ( "fmt" "testing" + "github.com/hashicorp/terraform/helper/acctest" "github.com/hashicorp/terraform/helper/resource" "github.com/hashicorp/terraform/terraform" ) @@ -16,7 +17,7 @@ func TestAccDataSourceGoogleSubnetwork(t *testing.T) { Providers: testAccProviders, Steps: []resource.TestStep{ resource.TestStep{ - Config: TestAccDataSourceGoogleSubnetworkConfig, + Config: testAccDataSourceGoogleSubnetwork(), Check: resource.ComposeTestCheckFunc( testAccDataSourceGoogleSubnetworkCheck("data.google_compute_subnetwork.my_subnetwork", "google_compute_subnetwork.foobar"), ), @@ -66,10 +67,11 @@ func testAccDataSourceGoogleSubnetworkCheck(data_source_name string, resource_na } } -var TestAccDataSourceGoogleSubnetworkConfig = ` +func testAccDataSourceGoogleSubnetwork() string { + return fmt.Sprintf(` resource "google_compute_network" "foobar" { - name = "network-test" + name = "%s" description = "my-description" } resource "google_compute_subnetwork" "foobar" { @@ -87,4 +89,5 @@ resource "google_compute_subnetwork" "foobar" { data "google_compute_subnetwork" "my_subnetwork" { name = "${google_compute_subnetwork.foobar.name}" } -` +`, acctest.RandomWithPrefix("network-test")) +}