From 8b6a334ff91ba8cd9bd65fd598ee2aa087e03bea Mon Sep 17 00:00:00 2001 From: The Magician Date: Fri, 29 Mar 2019 15:12:51 -0700 Subject: [PATCH] Shuffle schema in BackendService around to match what MM will do (#3340) /cc @rileykarson --- google/resource_compute_backend_service.go | 172 +++++++++++---------- 1 file changed, 88 insertions(+), 84 deletions(-) diff --git a/google/resource_compute_backend_service.go b/google/resource_compute_backend_service.go index 0ad4c183..34f4fc39 100644 --- a/google/resource_compute_backend_service.go +++ b/google/resource_compute_backend_service.go @@ -38,78 +38,16 @@ func resourceComputeBackendService() *schema.Resource { MaxItems: 1, }, - "iap": { - Type: schema.TypeList, + "affinity_cookie_ttl_sec": { + Type: schema.TypeInt, Optional: true, - MaxItems: 1, - Elem: &schema.Resource{ - Schema: map[string]*schema.Schema{ - "oauth2_client_id": { - Type: schema.TypeString, - Required: true, - }, - "oauth2_client_secret": { - Type: schema.TypeString, - Required: true, - Sensitive: true, - }, - "oauth2_client_secret_sha256": { - Type: schema.TypeString, - Computed: true, - Sensitive: true, - }, - }, - }, }, "backend": { Type: schema.TypeSet, Optional: true, Set: resourceGoogleComputeBackendServiceBackendHash, - Elem: &schema.Resource{ - Schema: map[string]*schema.Schema{ - "group": { - Type: schema.TypeString, - Optional: true, - DiffSuppressFunc: compareSelfLinkRelativePaths, - }, - "balancing_mode": { - Type: schema.TypeString, - Optional: true, - Default: "UTILIZATION", - }, - "capacity_scaler": { - Type: schema.TypeFloat, - Optional: true, - Default: 1, - }, - "description": { - Type: schema.TypeString, - Optional: true, - }, - "max_rate": { - Type: schema.TypeInt, - Optional: true, - }, - "max_rate_per_instance": { - Type: schema.TypeFloat, - Optional: true, - }, - "max_connections": { - Type: schema.TypeInt, - Optional: true, - }, - "max_connections_per_instance": { - Type: schema.TypeInt, - Optional: true, - }, - "max_utilization": { - Type: schema.TypeFloat, - Optional: true, - Default: 0.8, - }, - }, - }, + Elem: computeBackendServiceBackendSchema(), }, "cdn_policy": { @@ -156,6 +94,12 @@ func resourceComputeBackendService() *schema.Resource { }, }, + "connection_draining_timeout_sec": { + Type: schema.TypeInt, + Optional: true, + Default: 300, + }, + "custom_request_headers": { Removed: "This field is in beta. Use it in the the google-beta provider instead. See https://terraform.io/docs/providers/google/provider_versions.html for more details.", Type: schema.TypeSet, @@ -180,19 +124,36 @@ func resourceComputeBackendService() *schema.Resource { Computed: true, }, + "iap": { + Type: schema.TypeList, + Optional: true, + MaxItems: 1, + Elem: &schema.Resource{ + Schema: map[string]*schema.Schema{ + "oauth2_client_id": { + Type: schema.TypeString, + Required: true, + }, + "oauth2_client_secret": { + Type: schema.TypeString, + Required: true, + Sensitive: true, + }, + "oauth2_client_secret_sha256": { + Type: schema.TypeString, + Computed: true, + Sensitive: true, + }, + }, + }, + }, + "port_name": { Type: schema.TypeString, Optional: true, Computed: true, }, - "project": { - Type: schema.TypeString, - Optional: true, - Computed: true, - ForceNew: true, - }, - "protocol": { Type: schema.TypeString, Optional: true, @@ -212,32 +173,75 @@ func resourceComputeBackendService() *schema.Resource { DiffSuppressFunc: compareSelfLinkOrResourceName, }, - "self_link": { - Type: schema.TypeString, - Computed: true, - }, - "session_affinity": { Type: schema.TypeString, Optional: true, Computed: true, }, - "affinity_cookie_ttl_sec": { - Type: schema.TypeInt, - Optional: true, - }, - "timeout_sec": { Type: schema.TypeInt, Optional: true, Computed: true, }, - "connection_draining_timeout_sec": { + "project": { + Type: schema.TypeString, + Optional: true, + Computed: true, + ForceNew: true, + }, + + "self_link": { + Type: schema.TypeString, + Computed: true, + }, + }, + } +} + +func computeBackendServiceBackendSchema() *schema.Resource { + return &schema.Resource{ + Schema: map[string]*schema.Schema{ + "group": { + Type: schema.TypeString, + Optional: true, + DiffSuppressFunc: compareSelfLinkRelativePaths, + }, + "balancing_mode": { + Type: schema.TypeString, + Optional: true, + Default: "UTILIZATION", + }, + "capacity_scaler": { + Type: schema.TypeFloat, + Optional: true, + Default: 1, + }, + "description": { + Type: schema.TypeString, + Optional: true, + }, + "max_rate": { Type: schema.TypeInt, Optional: true, - Default: 300, + }, + "max_rate_per_instance": { + Type: schema.TypeFloat, + Optional: true, + }, + "max_connections": { + Type: schema.TypeInt, + Optional: true, + }, + "max_connections_per_instance": { + Type: schema.TypeInt, + Optional: true, + }, + "max_utilization": { + Type: schema.TypeFloat, + Optional: true, + Default: 0.8, }, }, }