public/terraform-provider-google
0
0
Fork 0
mirror of https://github.com/letic/terraform-provider-google.git synced 2024-07-06 02:02:43 +00:00
Code Issues Projects Releases Wiki Activity

Fix issue with nondeterminism in tests (#226)

Browse Source
This commit is contained in:
Joe Selman 2017-07-28 12:59:19 -07:00 committed by GitHub
parent cb538a3535
commit 88b1f092ff
1 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
google/resource_compute_project_metadata_item_test.go
View File

@ -4,20 +4,24 @@ import (
"fmt" "fmt"
"testing" "testing"
"github.com/hashicorp/terraform/helper/acctest"
"github.com/hashicorp/terraform/helper/resource" "github.com/hashicorp/terraform/helper/resource"
"github.com/hashicorp/terraform/terraform" "github.com/hashicorp/terraform/terraform"
) )
func TestAccComputeProjectMetadataItem_basic(t *testing.T) { func TestAccComputeProjectMetadataItem_basic(t *testing.T) {
// Key must be unique to avoid concurrent tests interfering with each other
key := "myKey" + acctest.RandString(10)
resource.Test(t, resource.TestCase{ resource.Test(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) }, PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProviders, Providers: testAccProviders,
CheckDestroy: testAccCheckProjectMetadataItemDestroy, CheckDestroy: testAccCheckProjectMetadataItemDestroy,
Steps: []resource.TestStep{ Steps: []resource.TestStep{
{ {
Config: testAccProjectMetadataItem_basic("myKey", "myValue"), Config: testAccProjectMetadataItem_basic(key, "myValue"),
Check: resource.ComposeTestCheckFunc( Check: resource.ComposeTestCheckFunc(
testAccCheckProjectMetadataItem_hasMetadata("myKey", "myValue"), testAccCheckProjectMetadataItem_hasMetadata(key, "myValue"),
), ),
}, },
}, },
@ -25,15 +29,18 @@ func TestAccComputeProjectMetadataItem_basic(t *testing.T) {
} }
func TestAccComputeProjectMetadataItem_basicWithEmptyVal(t *testing.T) { func TestAccComputeProjectMetadataItem_basicWithEmptyVal(t *testing.T) {
// Key must be unique to avoid concurrent tests interfering with each other
key := "myKey" + acctest.RandString(10)
resource.Test(t, resource.TestCase{ resource.Test(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) }, PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProviders, Providers: testAccProviders,
CheckDestroy: testAccCheckProjectMetadataItemDestroy, CheckDestroy: testAccCheckProjectMetadataItemDestroy,
Steps: []resource.TestStep{ Steps: []resource.TestStep{
{ {
Config: testAccProjectMetadataItem_basic("myKey", ""), Config: testAccProjectMetadataItem_basic(key, ""),
Check: resource.ComposeTestCheckFunc( Check: resource.ComposeTestCheckFunc(
testAccCheckProjectMetadataItem_hasMetadata("myKey", ""), testAccCheckProjectMetadataItem_hasMetadata(key, ""),
), ),
}, },
}, },
@ -41,21 +48,24 @@ func TestAccComputeProjectMetadataItem_basicWithEmptyVal(t *testing.T) {
} }
func TestAccComputeProjectMetadataItem_basicUpdate(t *testing.T) { func TestAccComputeProjectMetadataItem_basicUpdate(t *testing.T) {
// Key must be unique to avoid concurrent tests interfering with each other
key := "myKey" + acctest.RandString(10)
resource.Test(t, resource.TestCase{ resource.Test(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) }, PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProviders, Providers: testAccProviders,
CheckDestroy: testAccCheckProjectMetadataItemDestroy, CheckDestroy: testAccCheckProjectMetadataItemDestroy,
Steps: []resource.TestStep{ Steps: []resource.TestStep{
{ {
Config: testAccProjectMetadataItem_basic("myKey", "myValue"), Config: testAccProjectMetadataItem_basic(key, "myValue"),
Check: resource.ComposeTestCheckFunc( Check: resource.ComposeTestCheckFunc(
testAccCheckProjectMetadataItem_hasMetadata("myKey", "myValue"), testAccCheckProjectMetadataItem_hasMetadata(key, "myValue"),
), ),
}, },
{ {
Config: testAccProjectMetadataItem_basic("myKey", "myUpdatedValue"), Config: testAccProjectMetadataItem_basic(key, "myUpdatedValue"),
Check: resource.ComposeTestCheckFunc( Check: resource.ComposeTestCheckFunc(
testAccCheckProjectMetadataItem_hasMetadata("myKey", "myUpdatedValue"), testAccCheckProjectMetadataItem_hasMetadata(key, "myUpdatedValue"),
), ),
}, },
}, },