public/terraform-provider-google
0
0
Fork 0
mirror of https://github.com/letic/terraform-provider-google.git synced 2024-07-03 08:42:39 +00:00
Code Issues Projects Releases Wiki Activity

MergeBindings ignores empty bindings. (#1344)

Browse Source
This commit is contained in:
Nathan McKinley 2018-04-16 13:13:09 -07:00 committed by GitHub
parent 152df5ad6e
commit 7d92392a3e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
google/iam.go
View File

@ -129,7 +129,9 @@ func mergeBindings(bindings []*cloudresourcemanager.Binding) []*cloudresourceman
for m := range members {
b.Members = append(b.Members, m)
}
rb = append(rb, &b)
if len(b.Members) > 0 {
rb = append(rb, &b)
}
}
return rb

1
google/resource_google_project_iam_policy_test.go
View File

@ -594,6 +594,7 @@ func TestIamMergeBindings(t *testing.T) {
"member-2",
},
},
{Role: "empty-role", Members: []string{}},
},
expect: []cloudresourcemanager.Binding{
{