From 72b759dbd3dc89ada7ed96c3379bbb387923e7c1 Mon Sep 17 00:00:00 2001 From: Riley Karson Date: Thu, 20 Sep 2018 12:43:55 -0700 Subject: [PATCH] Remove binary_log_enabled from Postgres test, as it's unsupported (#2075) \+ update docs. This must have silently failed in the API before? It doesn't work & is tested upstream now. Binary logs are a non-feature of Postgres. --- google/resource_sql_database_instance_test.go | 1 - website/docs/r/sql_database_instance.html.markdown | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/google/resource_sql_database_instance_test.go b/google/resource_sql_database_instance_test.go index 87c0f03b..2de61390 100644 --- a/google/resource_sql_database_instance_test.go +++ b/google/resource_sql_database_instance_test.go @@ -1105,7 +1105,6 @@ resource "google_sql_database_instance" "instance" { backup_configuration { enabled = true - binary_log_enabled = true } } } diff --git a/website/docs/r/sql_database_instance.html.markdown b/website/docs/r/sql_database_instance.html.markdown index bcbc7114..e6c7de77 100644 --- a/website/docs/r/sql_database_instance.html.markdown +++ b/website/docs/r/sql_database_instance.html.markdown @@ -190,7 +190,7 @@ The optional `settings.database_flags` sublist supports: The optional `settings.backup_configuration` subblock supports: * `binary_log_enabled` - (Optional) True if binary logging is enabled. If - `logging` is false, this must be as well. + `logging` is false, this must be as well. Cannot be used with Postgres. * `enabled` - (Optional) True if backup configuration is enabled.