From 6b1b7274490357195998689965f393ab88efda1d Mon Sep 17 00:00:00 2001 From: Paddy Date: Fri, 15 Sep 2017 13:08:37 -0700 Subject: [PATCH] Fix failing test on storage_object_acl. The `predefined_acl` test for `storage_object_acl` was failing. This is because we removed the state-setting portion of the `predefined_acl` field from `storage_bucket_acl`, and due to what I can only assume is a copy/paste error, `storage_object_acl` was calling the Read function of `storage_bucket_acl` instead of its own when using `predefined_acl`. Updating to use `storage_object_acl`'s Read function makes the tests pass. --- google/resource_storage_object_acl.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/google/resource_storage_object_acl.go b/google/resource_storage_object_acl.go index 718260d9..05b39620 100644 --- a/google/resource_storage_object_acl.go +++ b/google/resource_storage_object_acl.go @@ -84,7 +84,7 @@ func resourceStorageObjectAclCreate(d *schema.ResourceData, meta interface{}) er return fmt.Errorf("Error updating object %s: %v", bucket, err) } - return resourceStorageBucketAclRead(d, meta) + return resourceStorageObjectAclRead(d, meta) } else if len(role_entity) > 0 { for _, v := range role_entity { pair, err := getRoleEntityPair(v.(string))