public/terraform-provider-google
0
0
Fork 0
mirror of https://github.com/letic/terraform-provider-google.git synced 2024-07-01 15:52:39 +00:00
Code Issues Projects Releases Wiki Activity

Fix incorrect arguments for google_compute_instance data source (#2874)

Browse Source 
Fixes #2535
This commit is contained in:
Yong Wen Chua 2019-01-16 03:27:57 +08:00 committed by Riley Karson
parent 6d3add75fc
commit 51bf081722
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
google/data_source_google_compute_instance.go
View File

@ -2,6 +2,7 @@ package google
import (
"fmt"
"github.com/hashicorp/terraform/helper/schema"
)
@ -9,11 +10,8 @@ func dataSourceGoogleComputeInstance() *schema.Resource {
// Generate datasource schema from resource
dsSchema := datasourceSchemaFromResourceSchema(resourceComputeInstance().Schema)
// Set 'Required' schema elements
addRequiredFieldsToSchema(dsSchema, "name")
// Set 'Optional' schema elements
addOptionalFieldsToSchema(dsSchema, "project", "zone")
addOptionalFieldsToSchema(dsSchema, "name", "self_link", "project", "zone")
return &schema.Resource{
Read: dataSourceGoogleComputeInstanceRead,

4
google/data_source_google_compute_instance_test.go
View File

@ -129,5 +129,9 @@ data "google_compute_instance" "bar" {
name = "${google_compute_instance.foo.name}"
zone = "us-central1-a"
}
data "google_compute_instance" "baz" {
self_link = "${google_compute_instance.foo.self_link}"
}
`, instanceName)
}