From 400a764f38fa35536644470f57b1cf297d55bdb3 Mon Sep 17 00:00:00 2001 From: Paddy Date: Wed, 29 Nov 2017 17:17:33 -0800 Subject: [PATCH] Clean up silly variable use. --- google/resource_dns_record_set.go | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/google/resource_dns_record_set.go b/google/resource_dns_record_set.go index 0c4c6fe2..812e7997 100644 --- a/google/resource_dns_record_set.go +++ b/google/resource_dns_record_set.go @@ -180,15 +180,12 @@ func resourceDnsRecordSetDelete(d *schema.ResourceData, meta interface{}) error // CAN and MUST be deleted, so we need to retrieve the managed zone, // check if what we're looking at is a subdomain, and only not delete // if it's not actually a subdomain - var domain string if d.Get("type").(string) == "NS" { - if domain == "" { - mz, err := config.clientDns.ManagedZones.Get(project, zone).Do() - if err != nil { - return fmt.Errorf("Error retrieving managed zone %q from %q: %s", zone, project, err) - } - domain = mz.DnsName + mz, err := config.clientDns.ManagedZones.Get(project, zone).Do() + if err != nil { + return fmt.Errorf("Error retrieving managed zone %q from %q: %s", zone, project, err) } + domain := mz.DnsName if domain == d.Get("name").(string) { log.Println("[DEBUG] NS records can't be deleted due to API restrictions, so they're being left in place. See https://www.terraform.io/docs/providers/google/r/dns_record_set.html for more information.")