public/terraform-provider-google
0
0
Fork 0
mirror of https://github.com/letic/terraform-provider-google.git synced 2024-06-29 06:42:36 +00:00
Code Issues Projects Releases Wiki Activity

Fix forwarding rule fields and add Internal LB example (#3489)

Browse Source 
Signed-off-by: Modular Magician <magic-modules@google.com>
This commit is contained in:
The Magician 2019-04-26 10:54:26 -07:00 committed by emily
parent 2e7d7a6fb3
commit 13b49cfcb0
4 changed files with 138 additions and 138 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
google/resource_compute_forwarding_rule.go
View File

@ -82,6 +82,7 @@ func resourceComputeForwardingRule() *schema.Resource {
"ip_version": {
Type: schema.TypeString,
Optional: true,
Deprecated: "ipVersion is not used for regional forwarding rules. Please remove this field if you are using it.",
ForceNew: true,
ValidateFunc: validation.StringInSlice([]string{"IPV4", "IPV6", ""}, false),
},

70
google/resource_compute_forwarding_rule_generated_test.go
View File

@ -51,7 +51,7 @@ func TestAccComputeForwardingRule_forwardingRuleBasicExample(t *testing.T) {
func testAccComputeForwardingRule_forwardingRuleBasicExample(context map[string]interface{}) string {
return Nprintf(`
resource "google_compute_forwarding_rule" "default" {
name = "website-forwarding-rule-%{random_suffix}"
name = ""
target = "${google_compute_target_pool.default.self_link}"
port_range = "80"
}
@ -62,6 +62,74 @@ resource "google_compute_target_pool" "default" {
`, context)
}
func TestAccComputeForwardingRule_forwardingRuleInternallbExample(t *testing.T) {
t.Parallel()
context := map[string]interface{}{
"random_suffix": acctest.RandString(10),
}
resource.Test(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProviders,
CheckDestroy: testAccCheckComputeForwardingRuleDestroy,
Steps: []resource.TestStep{
{
Config: testAccComputeForwardingRule_forwardingRuleInternallbExample(context),
},
{
ResourceName: "google_compute_forwarding_rule.default",
ImportState: true,
ImportStateVerify: true,
},
},
})
}
func testAccComputeForwardingRule_forwardingRuleInternallbExample(context map[string]interface{}) string {
return Nprintf(`
// Forwarding rule for Internal Load Balancing
resource "google_compute_forwarding_rule" "default" {
name = "website-forwarding-rule-%{random_suffix}"
region = "us-central1"
load_balancing_scheme = "INTERNAL"
backend_service = "${google_compute_region_backend_service.backend.self_link}"
all_ports = true
network = "${google_compute_network.default.name}"
subnetwork = "${google_compute_subnetwork.default.name}"
}
resource "google_compute_region_backend_service" "backend" {
name = "website-backend-%{random_suffix}"
region = "us-central1"
health_checks = ["${google_compute_health_check.hc.self_link}"]
}
resource "google_compute_health_check" "hc" {
name = "check-website-backend-%{random_suffix}"
check_interval_sec = 1
timeout_sec = 1
tcp_health_check {
port = "80"
}
}
resource "google_compute_network" "default" {
name = "website-net-%{random_suffix}"
auto_create_subnetworks = false
}
resource "google_compute_subnetwork" "default" {
name = "website-net-%{random_suffix}"
ip_cidr_range = "10.0.0.0/16"
region = "us-central1"
network = "${google_compute_network.default.self_link}"
}
`, context)
}
func testAccCheckComputeForwardingRuleDestroy(s *terraform.State) error {
for name, rs := range s.RootModule().Resources {
if rs.Type != "google_compute_forwarding_rule" {

114
google/resource_compute_forwarding_rule_test.go
View File

@ -39,29 +39,6 @@ func TestAccComputeForwardingRule_update(t *testing.T) {
})
}
func TestAccComputeForwardingRule_singlePort(t *testing.T) {
t.Parallel()
poolName := fmt.Sprintf("tf-%s", acctest.RandString(10))
ruleName := fmt.Sprintf("tf-%s", acctest.RandString(10))
resource.Test(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProviders,
CheckDestroy: testAccCheckComputeForwardingRuleDestroy,
Steps: []resource.TestStep{
{
Config: testAccComputeForwardingRule_singlePort(poolName, ruleName),
},
{
ResourceName: "google_compute_forwarding_rule.foobar",
ImportState: true,
ImportStateVerify: true,
},
},
})
}
func TestAccComputeForwardingRule_ip(t *testing.T) {
t.Parallel()
@ -86,37 +63,6 @@ func TestAccComputeForwardingRule_ip(t *testing.T) {
})
}
func TestAccComputeForwardingRule_internalLoadBalancing(t *testing.T) {
t.Parallel()
serviceName := fmt.Sprintf("tf-%s", acctest.RandString(10))
checkName := fmt.Sprintf("tf-%s", acctest.RandString(10))
networkName := fmt.Sprintf("tf-%s", acctest.RandString(10))
ruleName1 := fmt.Sprintf("tf-%s", acctest.RandString(10))
ruleName2 := fmt.Sprintf("tf-%s", acctest.RandString(10))
resource.Test(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProviders,
CheckDestroy: testAccCheckComputeForwardingRuleDestroy,
Steps: []resource.TestStep{
{
Config: testAccComputeForwardingRule_internalLoadBalancing(serviceName, checkName, networkName, ruleName1, ruleName2),
},
{
ResourceName: "google_compute_forwarding_rule.foobar",
ImportState: true,
ImportStateVerify: true,
},
{
ResourceName: "google_compute_forwarding_rule.foobar2",
ImportState: true,
ImportStateVerify: true,
},
},
})
}
func TestAccComputeForwardingRule_networkTier(t *testing.T) {
t.Parallel()
@ -180,23 +126,6 @@ resource "google_compute_forwarding_rule" "foobar" {
`, poolName, poolName, ruleName)
}
func testAccComputeForwardingRule_singlePort(poolName, ruleName string) string {
return fmt.Sprintf(`
resource "google_compute_target_pool" "foobar-tp" {
description = "Resource created for Terraform acceptance testing"
instances = ["us-central1-a/foo", "us-central1-b/bar"]
name = "%s"
}
resource "google_compute_forwarding_rule" "foobar" {
description = "Resource created for Terraform acceptance testing"
ip_protocol = "UDP"
name = "%s"
port_range = "80"
target = "${google_compute_target_pool.foobar-tp.self_link}"
}
`, poolName, ruleName)
}
func testAccComputeForwardingRule_ip(addrName, poolName, ruleName string) string {
return fmt.Sprintf(`
resource "google_compute_address" "foo" {
@ -218,49 +147,6 @@ resource "google_compute_forwarding_rule" "foobar" {
`, addrName, poolName, ruleName)
}
func testAccComputeForwardingRule_internalLoadBalancing(serviceName, checkName, networkName, ruleName1, ruleName2 string) string {
return fmt.Sprintf(`
resource "google_compute_region_backend_service" "foobar-bs" {
name = "%s"
description = "Resource created for Terraform acceptance testing"
health_checks = ["${google_compute_health_check.zero.self_link}"]
region = "us-central1"
}
resource "google_compute_health_check" "zero" {
name = "%s"
description = "Resource created for Terraform acceptance testing"
check_interval_sec = 1
timeout_sec = 1
tcp_health_check {
port = "80"
}
}
resource "google_compute_network" "foobar" {
name = "%s"
auto_create_subnetworks = true
}
resource "google_compute_forwarding_rule" "foobar" {
description = "Resource created for Terraform acceptance testing"
name = "%s"
load_balancing_scheme = "INTERNAL"
backend_service = "${google_compute_region_backend_service.foobar-bs.self_link}"
all_ports = true
network = "${google_compute_network.foobar.name}"
subnetwork = "%s"
}
resource "google_compute_forwarding_rule" "foobar2" {
description = "Resource created for Terraform acceptance testing"
name = "%s"
load_balancing_scheme = "INTERNAL"
backend_service = "${google_compute_region_backend_service.foobar-bs.self_link}"
ports = ["80"]
network = "${google_compute_network.foobar.self_link}"
service_label = "foobar"
}
`, serviceName, checkName, networkName, ruleName1, networkName, ruleName2)
}
func testAccComputeForwardingRule_networkTier(poolName, ruleName string) string {
return fmt.Sprintf(`
resource "google_compute_target_pool" "foobar-tp" {

91
website/docs/r/compute_forwarding_rule.html.markdown
View File

@ -42,7 +42,7 @@ To get more information about ForwardingRule, see:
```hcl
resource "google_compute_forwarding_rule" "default" {
name = "website-forwarding-rule"
name = ""
target = "${google_compute_target_pool.default.self_link}"
port_range = "80"
}
@ -51,6 +51,55 @@ resource "google_compute_target_pool" "default" {
name = "website-target-pool"
}
```
<div class = "oics-button" style="float: right; margin: 0 0 -15px">
<a href="https://console.cloud.google.com/cloudshell/open?cloudshell_git_repo=https%3A%2F%2Fgithub.com%2Fterraform-google-modules%2Fdocs-examples.git&cloudshell_working_dir=forwarding_rule_internallb&cloudshell_image=gcr.io%2Fgraphite-cloud-shell-images%2Fterraform%3Alatest&open_in_editor=main.tf&cloudshell_print=.%2Fmotd&cloudshell_tutorial=.%2Ftutorial.md" target="_blank">
<img alt="Open in Cloud Shell" src="//gstatic.com/cloudssh/images/open-btn.svg" style="max-height: 44px; margin: 32px auto; max-width: 100%;">
</a>
</div>
## Example Usage - Forwarding Rule Internallb
```hcl
// Forwarding rule for Internal Load Balancing
resource "google_compute_forwarding_rule" "default" {
name = "website-forwarding-rule"
region = "us-central1"
load_balancing_scheme = "INTERNAL"
backend_service = "${google_compute_region_backend_service.backend.self_link}"
all_ports = true
network = "${google_compute_network.default.name}"
subnetwork = "${google_compute_subnetwork.default.name}"
}
resource "google_compute_region_backend_service" "backend" {
name = "website-backend"
region = "us-central1"
health_checks = ["${google_compute_health_check.hc.self_link}"]
}
resource "google_compute_health_check" "hc" {
name = "check-website-backend"
check_interval_sec = 1
timeout_sec = 1
tcp_health_check {
port = "80"
}
}
resource "google_compute_network" "default" {
name = "website-net"
auto_create_subnetworks = false
}
resource "google_compute_subnetwork" "default" {
name = "website-net"
ip_cidr_range = "10.0.0.0/16"
region = "us-central1"
network = "${google_compute_network.default.self_link}"
}
```
## Argument Reference
@ -113,15 +162,12 @@ The following arguments are supported:
* `backend_service` -
(Optional)
A reference to a BackendService to receive the matched traffic.
This is used for internal load balancing.
(not used for external load balancing)
A BackendService to receive the matched traffic. This is used only
for INTERNAL load balancing.
* `ip_version` -
(Optional)
The IP Version that will be used by this forwarding rule. Valid
options are IPV4 or IPV6. This can only be specified for a global
forwarding rule.
(Optional, Deprecated)
ipVersion is not a valid field for regional forwarding rules.
* `load_balancing_scheme` -
(Optional)
@ -136,7 +182,7 @@ The following arguments are supported:
For internal load balancing, this field identifies the network that
the load balanced IP should belong to for this Forwarding Rule. If
this field is not specified, the default network will be used.
This field is not used for external load balancing.
This field is only used for INTERNAL load balancing.
* `port_range` -
(Optional)
@ -169,28 +215,27 @@ The following arguments are supported:
* `subnetwork` -
(Optional)
A reference to a subnetwork.
For internal load balancing, this field identifies the subnetwork that
the load balanced IP should belong to for this Forwarding Rule.
The subnetwork that the load balanced IP should belong to for this
Forwarding Rule. This field is only used for INTERNAL load balancing.
If the network specified is in auto subnet mode, this field is
optional. However, if the network is in custom subnet mode, a
subnetwork must be specified.
This field is not used for external load balancing.
* `target` -
(Optional)
This field is only used for EXTERNAL load balancing.
A reference to a TargetPool resource to receive the matched traffic.
For regional forwarding rules, this target must live in the same
region as the forwarding rule. For global forwarding rules, this
target must be a global load balancing resource. The forwarded traffic
must be of a type appropriate to the target object.
This field is not used for internal load balancing.
This target must live in the same region as the forwarding rule.
The forwarded traffic must be of a type appropriate to the target
object.
* `all_ports` -
(Optional)
When the load balancing scheme is INTERNAL and protocol is TCP/UDP, omit
`port`/`port_range` and specify this field as `true` to allow packets addressed
to any ports to be forwarded to the backends configured with this forwarding rule.
For internal TCP/UDP load balancing (i.e. load balancing scheme is
INTERNAL and protocol is TCP/UDP), set this to true to allow packets
addressed to any ports to be forwarded to the backends configured
with this forwarding rule. Used with backend service. Cannot be set
if port or portRange are set.
* `network_tier` -
(Optional)
@ -209,7 +254,7 @@ The following arguments are supported:
character must be a lowercase letter, and all following characters
must be a dash, lowercase letter, or digit, except the last
character, which cannot be a dash.
This field is only used for internal load balancing.
This field is only used for INTERNAL load balancing.
* `region` -
(Optional)
@ -229,7 +274,7 @@ In addition to the arguments listed above, the following computed attributes are
* `service_name` -
The internal fully qualified service name for this Forwarding Rule.
This field is only used for internal load balancing.
This field is only used for INTERNAL load balancing.
* `self_link` - The URI of the created resource.