public/terraform-provider-google
0
0
Fork 0
mirror of https://github.com/letic/terraform-provider-google.git synced 2024-10-01 16:21:06 +00:00
Code Issues Projects Releases Wiki Activity

Address comments.

Browse Source 
Fix typo, add log line, and document what we're doing on the website.
This commit is contained in:
Paddy 2017-10-24 14:43:35 -07:00
parent b2ff683868
commit 0e2fa2e38f
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
google/resource_dns_record_set.go
View File

@ -78,7 +78,7 @@ func resourceDnsRecordSetCreate(d *schema.ResourceData, meta interface{}) error
}
if d.Get("type").(string) == "NS" {
log.Printf("{DEBUG] DNS record list request for %q", zone)
log.Printf("[DEBUG] DNS record list request for %q", zone)
res, err := config.clientDns.ResourceRecordSets.List(project, zone).Do()
if err != nil {
return fmt.Errorf("Error retrieving record sets for %q: %s", zone, err)
@ -159,6 +159,7 @@ func resourceDnsRecordSetDelete(d *schema.ResourceData, meta interface{}) error
// this allows terraform delete to work, but may have unexpected
// side-effects when deleting just that record set.
if d.Get("type").(string) == "NS" {
log.Println("[DEBUG] NS records can't be deleted due to API restrictions, so they're being left in place. See https://www.terraform.io/docs/providers/google/r/dns_record_set.html for more information.")
return nil
}
config := meta.(*Config)

6
website/docs/r/dns_record_set.markdown
View File

@ -10,6 +10,12 @@ description: |-
Manages a set of DNS records within Google Cloud DNS.
~> **Note:** The Google Cloud DNS API requires NS records be present at all
times. To accommodate this, when creating NS records, the default records
Google automatically creates will be silently overwritten. Also, when
destroying NS records, Terraform will not actually remove NS records, but will
report that it did.
## Example Usage
### Binding a DNS name to the ephemeral IP of a new instance: