From 0a02d8eaefaa216e25ce621d878bde10c5cb0b67 Mon Sep 17 00:00:00 2001 From: Nathan McKinley Date: Wed, 25 Apr 2018 13:26:24 -0700 Subject: [PATCH] Fix failing compute tests which use AccessConfigs (#1383) --- google/compute_instance_helpers.go | 2 +- google/resource_compute_instance.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/google/compute_instance_helpers.go b/google/compute_instance_helpers.go index 65b2a1f9..cc255df1 100644 --- a/google/compute_instance_helpers.go +++ b/google/compute_instance_helpers.go @@ -106,7 +106,7 @@ func expandAccessConfigs(configs []interface{}) []*computeBeta.AccessConfig { Type: "ONE_TO_ONE_NAT", NatIP: data["nat_ip"].(string), } - if ptr, ok := data["public_ptr_domain_name"]; ok { + if ptr, ok := data["public_ptr_domain_name"]; ok && ptr != "" { acs[i].SetPublicPtr = true acs[i].PublicPtrDomainName = ptr.(string) } diff --git a/google/resource_compute_instance.go b/google/resource_compute_instance.go index f7424b20..4812e45b 100644 --- a/google/resource_compute_instance.go +++ b/google/resource_compute_instance.go @@ -1125,7 +1125,7 @@ func resourceComputeInstanceUpdate(d *schema.ResourceData, meta interface{}) err Type: "ONE_TO_ONE_NAT", NatIP: d.Get(acPrefix + ".nat_ip").(string), } - if ptr, ok := d.GetOk(acPrefix + ".public_ptr_domain_name"); ok { + if ptr, ok := d.GetOk(acPrefix + ".public_ptr_domain_name"); ok && ptr != "" { ac.SetPublicPtr = true ac.PublicPtrDomainName = ptr.(string) }