From 868071587421cd6a14e79afd4b6a9af8984f6bf9 Mon Sep 17 00:00:00 2001
From: Tim Almdal <tnalmdal@shaw.ca>
Date: Wed, 10 Feb 2010 17:54:56 -0800
Subject: [PATCH 1/3] Gallery3::factory should be defined as static.

---
 client/Gallery3.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/Gallery3.php b/client/Gallery3.php
index 629a114d..f732394c 100644
--- a/client/Gallery3.php
+++ b/client/Gallery3.php
@@ -49,7 +49,7 @@ class Gallery3 {
    * @param   string authentication token
    * @return  object Gallery3
    */
-  public function factory($url=null, $token=null) {
+  static function factory($url=null, $token=null) {
     $obj = new Gallery3();
     $obj->token = $token;
     $obj->url = $url;

From 9ba230615770e67b3d8877d73efac28757696e0a Mon Sep 17 00:00:00 2001
From: Bharat Mediratta <bharat@menalto.com>
Date: Fri, 19 Feb 2010 11:26:26 -0800
Subject: [PATCH 2/3] Properly return groups for the guest user.

---
 modules/ldap/libraries/drivers/IdentityProvider/Ldap.php | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/modules/ldap/libraries/drivers/IdentityProvider/Ldap.php b/modules/ldap/libraries/drivers/IdentityProvider/Ldap.php
index 6eabc102..139eadf4 100644
--- a/modules/ldap/libraries/drivers/IdentityProvider/Ldap.php
+++ b/modules/ldap/libraries/drivers/IdentityProvider/Ldap.php
@@ -178,13 +178,16 @@ class IdentityProvider_Ldap_Driver implements IdentityProvider_Driver {
   public function groups() {
     $groups = array();
     foreach (self::$_params["groups"] as $group_name) {
-      $root = item::root();
       $groups[] = $this->lookup_group_by_name($group_name);
     }
     return $groups;
   }
 
   static function groups_for($user) {
+    if ($user->guest) {
+      return $user->groups;
+    }
+
     $result = ldap_search(self::$_connection, self::$_params["group_domain"],
                           "(memberUid=$user->name)");
 

From 45277812b5b9b423dd976123bfd6be521880f556 Mon Sep 17 00:00:00 2001
From: Andy Staudacher <andy.st@gmail.com>
Date: Sat, 27 Feb 2010 15:44:46 -0800
Subject: [PATCH 3/3] Update register module for changes to the identity
 provider API.

---
 modules/register/controllers/register.php |  2 +-
 modules/register/helpers/register.php     | 12 +++---------
 2 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/modules/register/controllers/register.php b/modules/register/controllers/register.php
index ec50d646..5271e311 100755
--- a/modules/register/controllers/register.php
+++ b/modules/register/controllers/register.php
@@ -61,7 +61,7 @@ class register_Controller extends Controller {
     } else {
       print json_encode(
         array("result" => "error",
-              "form" => $form->__toString()));
+              "form" => (string) $form));
     }
   }
 
diff --git a/modules/register/helpers/register.php b/modules/register/helpers/register.php
index d46b381c..ff961156 100644
--- a/modules/register/helpers/register.php
+++ b/modules/register/helpers/register.php
@@ -78,20 +78,14 @@ class register_Core {
   static function create_new_user($id) {
     $user = ORM::factory("pending_user", $id);
 
-    $password = md5(rand());
-    $new_user = identity::create_user($user->name, $user->full_name, $password);
-    $new_user->email = $user->email;
+    $password = md5(uniqid(mt_rand(), true));
+    $new_user = identity::create_user($user->name, $user->full_name, $password, $user->email);
     $new_user->url = $user->url;
     $new_user->admin = false;
     $new_user->guest = false;
     $new_user->save();
 
-    $default_group = module::get_var("registration", "default_group");
-    if (!empty($default_group)) {
-      identity::add_user_to_group($new_user, $default_group);
-    }
-
-    $user->hash =  md5(rand());
+    $user->hash =  md5(uniqid(mt_rand(), true));
     $user->state = 2;
     $user->save();
     self::send_user_created_confirmation($user, $password);