From 99ec99a16653782e5c81008128d32aeeb464193d Mon Sep 17 00:00:00 2001 From: Bharat Mediratta Date: Tue, 17 Nov 2009 14:06:04 -0800 Subject: [PATCH] Update to use the new page_type and page_subtype designations. --- modules/basket/controllers/basket.php | 8 +++--- modules/basket/views/basket.html.php | 2 +- modules/batchtag/helpers/batchtag_block.php | 16 +++++------ .../calendarview/controllers/calendarview.php | 4 +-- .../contactowner/controllers/contactowner.php | 6 ++-- modules/dynamic/controllers/dynamic.php | 2 +- .../embedlinks/helpers/embedlinks_block.php | 16 +++++++---- .../helpers/keeporiginal_event.php | 28 +++++++++---------- .../controllers/latestupdates.php | 4 +-- .../helpers/latestupdates_block.php | 4 +++ .../helpers/metadescription_theme.php | 12 +++++--- .../views/metadescription_block.html.php | 4 +-- modules/register/helpers/register_event.php | 2 +- modules/tag_cloud/helpers/tag_cloud_block.php | 2 +- modules/tagfaces/controllers/tagfaces.php | 5 ++-- modules/tagsmap/controllers/tagsmap.php | 2 +- themes/3nids_theme/3nids/views/page.html.php | 8 +++--- .../3nids_theme/3nids/views/sidebar.html.php | 8 +++--- .../modules/tagsmap/controllers/tagsmap.php | 2 +- .../controllers/comments_3nids.php | 4 +-- .../theme_3nids/controllers/movie_3nids.php | 2 +- .../theme_3nids/controllers/photo_3nids.php | 2 +- themes/night_wind/views/page.html.php | 8 +++--- themes/night_wind/views/sidebar.html.php | 8 +++--- 24 files changed, 86 insertions(+), 73 deletions(-) diff --git a/modules/basket/controllers/basket.php b/modules/basket/controllers/basket.php index 9bdbe20b..12841cde 100644 --- a/modules/basket/controllers/basket.php +++ b/modules/basket/controllers/basket.php @@ -21,7 +21,7 @@ class Basket_Controller extends Controller { public function view_basket() { - $template = new Theme_View("page.html", "basket"); + $template = new Theme_View("page.html", "other", "basket"); $view = new View("view_basket.html"); $view->basket = Session_Basket::get(); @@ -48,7 +48,7 @@ class Basket_Controller extends Controller { public function checkout () { - $template = new Theme_View("page.html", "basket"); + $template = new Theme_View("page.html", "other", "basket"); $view = new View("checkout.html"); @@ -89,7 +89,7 @@ class Basket_Controller extends Controller { $basket->email = $form->contact->email->value; $basket->phone = $form->contact->phone->value; - $template = new Theme_View("page.html", "basket"); + $template = new Theme_View("page.html", "other", "basket"); $form = new Forge("basket/complete", "", "post", array("id" => "confirm", "name" =>"confirm")); $view = new View("confirm_order.html"); @@ -149,7 +149,7 @@ Items Ordered: $basket->clear(); - $template = new Theme_View("page.html", "basket"); + $template = new Theme_View("page.html", "other", "basket"); $view = new View("order_complete.html"); $template->content = $view; print $template; diff --git a/modules/basket/views/basket.html.php b/modules/basket/views/basket.html.php index 8e98a480..0ca59326 100644 --- a/modules/basket/views/basket.html.php +++ b/modules/basket/views/basket.html.php @@ -18,7 +18,7 @@ * Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA. */ ?> - page_type != 'basket'): ?> + page_subtype != 'basket'): ?> contents) && ($basket->size() > 0)): ?>
" diff --git a/modules/batchtag/helpers/batchtag_block.php b/modules/batchtag/helpers/batchtag_block.php index 8bc3afc6..6987e861 100644 --- a/modules/batchtag/helpers/batchtag_block.php +++ b/modules/batchtag/helpers/batchtag_block.php @@ -24,13 +24,13 @@ class batchtag_block_Core { static function get($block_id, $theme) { $block = ""; - - // Only display on album pages that the user can edit. - $item = $theme->item(); - if (!$item->is_album() || !access::can("edit", $item)) { - return; - } - + + // Only display on album pages that the user can edit. + $item = $theme->item(); + if (!$item || !$item->is_album() || !access::can("edit", $item)) { + return; + } + switch ($block_id) { case "batch_tag": // Make a new sidebar block. @@ -54,7 +54,7 @@ class batchtag_block_Core { $group->submit("")->value(t("Add Tag")); $block->content->batch_tag_form = $form; - break; + break; } return $block; } diff --git a/modules/calendarview/controllers/calendarview.php b/modules/calendarview/controllers/calendarview.php index 1d323558..d91d0bdd 100644 --- a/modules/calendarview/controllers/calendarview.php +++ b/modules/calendarview/controllers/calendarview.php @@ -31,7 +31,7 @@ class CalendarView_Controller extends Controller { } // Draw the page. - $template = new Theme_View("page.html", "CalendarView"); + $template = new Theme_View("page.html", "other", "CalendarView"); $template->page_title = t("Gallery :: Calendar"); $template->content = new View("calendarview_year.html"); $template->content->calendar_year = $display_year; @@ -75,7 +75,7 @@ class CalendarView_Controller extends Controller { } // Set up the page. - $template = new Theme_View("page.html", "CalendarDayView"); + $template = new Theme_View("page.html", "other", "CalendarDayView"); $template->page_title = t("Gallery :: Calendar"); $template->set_global("page_size", $page_size); diff --git a/modules/contactowner/controllers/contactowner.php b/modules/contactowner/controllers/contactowner.php index 6759e6a4..eda03abf 100644 --- a/modules/contactowner/controllers/contactowner.php +++ b/modules/contactowner/controllers/contactowner.php @@ -41,7 +41,7 @@ class ContactOwner_Controller extends Controller { $sendmail_fields->submit("SendMessage")->value(t("Send")); // Set up and display the actual page. - $template = new Theme_View("page.html", "Contact"); + $template = new Theme_View("page.html", "other", "Contact"); $template->content = new View("contactowner_emailform.html"); $template->content->sendmail_form = $form; print $template; @@ -75,7 +75,7 @@ class ContactOwner_Controller extends Controller { $sendmail_fields->submit("SendMessage")->value(t("Send")); // Set up and display the actual page. - $template = new Theme_View("page.html", "Contact"); + $template = new Theme_View("page.html", "other", "Contact"); $template->content = new View("contactowner_emailform.html"); $template->content->sendmail_form = $form; print $template; @@ -122,7 +122,7 @@ class ContactOwner_Controller extends Controller { ->send(); // Display a message telling the visitor that their email has been sent. - $template = new Theme_View("page.html", "Contact"); + $template = new Theme_View("page.html", "other", "Contact"); $template->content = new View("contactowner_emailform.html"); $template->content->sendmail_form = t("Your Message Has Been Sent."); print $template; diff --git a/modules/dynamic/controllers/dynamic.php b/modules/dynamic/controllers/dynamic.php index 6b5f2915..568bd2ac 100644 --- a/modules/dynamic/controllers/dynamic.php +++ b/modules/dynamic/controllers/dynamic.php @@ -47,7 +47,7 @@ class Dynamic_Controller extends Controller { Kohana::show_404(); } - $template = new Theme_View("page.html", "dynamic"); + $template = new Theme_View("page.html", "other", "dynamic"); $template->set_global("page_size", $page_size); $template->set_global("children", ORM::factory("item") ->viewable() diff --git a/modules/embedlinks/helpers/embedlinks_block.php b/modules/embedlinks/helpers/embedlinks_block.php index 44539854..26a00ae9 100644 --- a/modules/embedlinks/helpers/embedlinks_block.php +++ b/modules/embedlinks/helpers/embedlinks_block.php @@ -24,19 +24,23 @@ class embedlinks_block_Core { static function get($block_id, $theme) { $block = ""; - + + if (!$theme->item()) { + return; + } + switch ($block_id) { case "embed_links_dialog": - // If displaying links in a dialog box is enabled then + // If displaying links in a dialog box is enabled then // insert buttons into the bottom of the side bar - // to open up the dialog window. + // to open up the dialog window. if (module::get_var("embedlinks", "DialogLinks") && $theme->item()) { $block = new Block(); $block->css_id = "g-embed-links-sidebar"; $block->title = t("Link To This Page"); $block->content = new View("embedlinks_sidebar.html"); } - break; + break; case "embed_links_album": // If the current item is an album and if "In Page" links are enabled then @@ -46,10 +50,10 @@ class embedlinks_block_Core { $block->css_id = "g-embed-links-album-sidebar"; $block->title = t("Links"); $block->content = new View("embedlinks_album_block.html"); - } + } break; } - + return $block; } } diff --git a/modules/keeporiginal/helpers/keeporiginal_event.php b/modules/keeporiginal/helpers/keeporiginal_event.php index 81e83e9c..ea1283b6 100644 --- a/modules/keeporiginal/helpers/keeporiginal_event.php +++ b/modules/keeporiginal/helpers/keeporiginal_event.php @@ -108,23 +108,23 @@ class keeporiginal_event_Core { @rename($old_original, $new_original); } } - } + } } - - static function site_menu($menu, $theme) { + + static function site_menu($menu, $theme) { // Create a menu option to restore the original photo. - $item = $theme->item(); + if ($item = $theme->item()) { + if ((access::can("view", $item)) && (access::can("edit", $item))) { + $original_image = VARPATH . "original/" . str_replace(VARPATH . "albums/", "", $item->file_path()); - if ((access::can("view", $item)) && (access::can("edit", $item))) { - $original_image = VARPATH . "original/" . str_replace(VARPATH . "albums/", "", $item->file_path()); - - if ($item->is_photo() && file_exists($original_image)) { - $menu->get("options_menu") - ->append(Menu::factory("link") - ->id("restore") - ->label(t("Restore original")) - ->css_id("g-keep-originals-link") - ->url(url::site("keeporiginal/restore/" . $item->id))); + if ($item->is_photo() && file_exists($original_image)) { + $menu->get("options_menu") + ->append(Menu::factory("link") + ->id("restore") + ->label(t("Restore original")) + ->css_id("g-keep-originals-link") + ->url(url::site("keeporiginal/restore/" . $item->id))); + } } } } diff --git a/modules/latestupdates/controllers/latestupdates.php b/modules/latestupdates/controllers/latestupdates.php index f68a3cb4..58fcd23f 100644 --- a/modules/latestupdates/controllers/latestupdates.php +++ b/modules/latestupdates/controllers/latestupdates.php @@ -70,7 +70,7 @@ class latestupdates_Controller extends Controller { } // Set up and display the actual page. - $template = new Theme_View("page.html", "LatestUpdates"); + $template = new Theme_View("page.html", "other", "LatestUpdates"); $template->page_title = t("Gallery :: Latest Updates"); $template->set_global("page_size", $itemsPerPage); $template->set_global("children", $children); @@ -128,7 +128,7 @@ class latestupdates_Controller extends Controller { } // Set up and display the actual page. - $template = new Theme_View("page.html", "LatestUpdates"); + $template = new Theme_View("page.html", "other", "LatestUpdates"); $template->page_title = t("Gallery :: Latest Updates"); $template->set_global("page_size", $itemsPerPage); $template->set_global("children", $items); diff --git a/modules/latestupdates/helpers/latestupdates_block.php b/modules/latestupdates/helpers/latestupdates_block.php index 94a63f8d..f1472d3a 100644 --- a/modules/latestupdates/helpers/latestupdates_block.php +++ b/modules/latestupdates/helpers/latestupdates_block.php @@ -25,6 +25,10 @@ class latestupdates_block_Core { static function get($block_id, $theme) { $block = ""; + if (!$theme->item()) { + return; + } + switch ($block_id) { case "latestupdates": // Determine the ID# of the current album. diff --git a/modules/metadescription/helpers/metadescription_theme.php b/modules/metadescription/helpers/metadescription_theme.php index b11af2f6..d3b13a9e 100644 --- a/modules/metadescription/helpers/metadescription_theme.php +++ b/modules/metadescription/helpers/metadescription_theme.php @@ -26,7 +26,7 @@ class metadescription_theme_Core { ->where("id", $theme->tag()) ->find_all(); - }elseif ($theme->item()) { + } elseif ($theme->item()) { // If the current page belongs to an item (album, photo, etc.), // look up any tags that have been applied to that item. $tagsItem = ORM::factory("tag") @@ -40,8 +40,12 @@ class metadescription_theme_Core { } // Load the meta tags into the top of the page. - $metaView = new View("metadescription_block.html"); - $metaView->tags = $tagsItem; - return $metaView; + // @todo: metadescription_block.html requires an item so for now, don't render it unless we + // have one. + if ($theme->item()) { + $metaView = new View("metadescription_block.html"); + $metaView->tags = $tagsItem; + return $metaView; + } } } diff --git a/modules/metadescription/views/metadescription_block.html.php b/modules/metadescription/views/metadescription_block.html.php index 990baf71..d80c79f0 100644 --- a/modules/metadescription/views/metadescription_block.html.php +++ b/modules/metadescription/views/metadescription_block.html.php @@ -9,14 +9,14 @@ } else { $metaTags = $metaTags . html::clean($tags[$counter]->name); } - } + } } // If $metaTags is empty, use the item's title instead. if ($metaTags == "") { $metaTags = html::clean($item->title); } - + $metaDescription = ""; $metaDescription = trim(nl2br(html::purify($item->description))); // If description is empty, use title instead. diff --git a/modules/register/helpers/register_event.php b/modules/register/helpers/register_event.php index 700ba2c2..a39e2bd9 100755 --- a/modules/register/helpers/register_event.php +++ b/modules/register/helpers/register_event.php @@ -27,7 +27,7 @@ class register_event { static function user_menu($menu, $theme) { $user = identity::active_user(); - if ($theme->page_type != "login" && $user->guest) { + if ($theme->page_subtype != "login" && $user->guest) { $menu->append(Menu::factory("dialog") ->id("user_menu_register") ->css_id("g-register-menu") diff --git a/modules/tag_cloud/helpers/tag_cloud_block.php b/modules/tag_cloud/helpers/tag_cloud_block.php index 460c14a1..1dbcb754 100644 --- a/modules/tag_cloud/helpers/tag_cloud_block.php +++ b/modules/tag_cloud/helpers/tag_cloud_block.php @@ -58,7 +58,7 @@ class tag_cloud_block { $block->content->cloud = tag::cloud(30); $block->content->options = $options; - if ($theme->item() && $theme->page_type() != "tag" && access::can("edit", $theme->item())) { + if ($theme->item() && $theme->page_subtype() != "tag" && access::can("edit", $theme->item())) { $controller = new Tags_Controller(); $block->content->form = tag::get_add_form($theme->item()); } else { diff --git a/modules/tagfaces/controllers/tagfaces.php b/modules/tagfaces/controllers/tagfaces.php index 299dfec6..7fb5e47a 100644 --- a/modules/tagfaces/controllers/tagfaces.php +++ b/modules/tagfaces/controllers/tagfaces.php @@ -27,10 +27,11 @@ class tagfaces_Controller extends Controller { access::required("edit", $item); // Create the page. - $template = new Theme_View("page.html", "drawfaces"); + $template = new Theme_View("page.html", "other", "drawfaces"); $template->set_global("item_id", $id); $template->set_global("page_title", t("Draw Faces")); - $template->set_global("page_type", "photoface"); + $template->set_global("page_type", "other"); + $template->set_global("page_subtype", "photoface"); $template->content = new View("drawfaces.html"); $template->content->title = t("Tag Faces"); $template->content->form = $this->_get_faces_form($id); diff --git a/modules/tagsmap/controllers/tagsmap.php b/modules/tagsmap/controllers/tagsmap.php index 6150f62b..e4ddbe9f 100644 --- a/modules/tagsmap/controllers/tagsmap.php +++ b/modules/tagsmap/controllers/tagsmap.php @@ -41,7 +41,7 @@ class TagsMap_Controller extends Controller { print $view; } else { - $template = new Theme_View("page.html", "TagsMap"); + $template = new Theme_View("page.html", "other", "TagsMap"); $template->page_title = t("Gallery :: Map"); $template->content = new View("tagsmap_googlemap.html"); diff --git a/themes/3nids_theme/3nids/views/page.html.php b/themes/3nids_theme/3nids/views/page.html.php index 0323c80d..9658873e 100755 --- a/themes/3nids_theme/3nids/views/page.html.php +++ b/themes/3nids_theme/3nids/views/page.html.php @@ -35,7 +35,7 @@ " media="screen,print,projection" /> - page_type == 'album'): ?> + page_type == 'collection'): ?> @@ -65,10 +65,10 @@ script("ui.init.js") ?> head() they get combined */ ?> - page_type == "photo"): ?> + page_subtype == "photo"): ?> script("jquery.scrollTo.js") ?> script("gallery.show_full_size.js") ?> - page_type == "movie"): ?> + page_subtype == "movie"): ?> script("flowplayer.js") ?> @@ -149,7 +149,7 @@
- page_type != "login"): ?> + page_subtype != "login"): ?>
diff --git a/themes/3nids_theme/3nids/views/sidebar.html.php b/themes/3nids_theme/3nids/views/sidebar.html.php index afa148c9..54f1d00d 100755 --- a/themes/3nids_theme/3nids/views/sidebar.html.php +++ b/themes/3nids_theme/3nids/views/sidebar.html.php @@ -2,13 +2,13 @@ sidebar_top() ?>
- + album_menu() ?> - + photo_menu() ?> - + movie_menu() ?> - + tag_menu() ?>
diff --git a/themes/3nids_theme/modules/tagsmap/controllers/tagsmap.php b/themes/3nids_theme/modules/tagsmap/controllers/tagsmap.php index d7985667..60e9c1c9 100755 --- a/themes/3nids_theme/modules/tagsmap/controllers/tagsmap.php +++ b/themes/3nids_theme/modules/tagsmap/controllers/tagsmap.php @@ -41,7 +41,7 @@ class TagsMap_Controller extends Controller { print $view; } else { - $template = new Theme_View("page.html", "Contact"); + $template = new Theme_View("page.html", "other", "Contact"); //$template->body_attributes("onload=\"GLoad\" onunload=\"Gunload\""); $template->page_title = t("Gallery :: map"); $template->content = new View("tagsmap_googlemap.html"); diff --git a/themes/3nids_theme/modules/theme_3nids/controllers/comments_3nids.php b/themes/3nids_theme/modules/theme_3nids/controllers/comments_3nids.php index 965762d3..f45e54e2 100755 --- a/themes/3nids_theme/modules/theme_3nids/controllers/comments_3nids.php +++ b/themes/3nids_theme/modules/theme_3nids/controllers/comments_3nids.php @@ -49,7 +49,7 @@ class Comments_3nids_Controller extends REST_Controller { break; case "html": - $view = new Theme_View("comments.html", "page"); + $view = new Theme_View("comments.html", "other", "page"); $view->comments = $comments; $view->item_id = $item_id; $view->thumb = $item->thumb_url(); @@ -122,7 +122,7 @@ class Comments_3nids_Controller extends REST_Controller { "created" => $comment->created, "text" => nl2br(html::purify($comment->text))))); } else { - $view = new Theme_View("comment.html", "fragment"); + $view = new Theme_View("comment.html", "other", "fragment"); $view->comment = $comment; print $view; } diff --git a/themes/3nids_theme/modules/theme_3nids/controllers/movie_3nids.php b/themes/3nids_theme/modules/theme_3nids/controllers/movie_3nids.php index 151002e9..fd938c32 100755 --- a/themes/3nids_theme/modules/theme_3nids/controllers/movie_3nids.php +++ b/themes/3nids_theme/modules/theme_3nids/controllers/movie_3nids.php @@ -29,7 +29,7 @@ class Movie_3nids_Controller extends REST_Controller { $item = ORM::factory("item", $item_id); access::required("view", $item); - $view = new Theme_View("movie_3nids.html", "page"); + $view = new Theme_View("movie_3nids.html", "other", "page"); $view->item = $item; $view->attrs = array("class" => "g-movie", "id" => "g-movie-id-{$item->id}", "style" => "display:block;width:{$item->width}px;height:{$item->height}px"); print $view; diff --git a/themes/3nids_theme/modules/theme_3nids/controllers/photo_3nids.php b/themes/3nids_theme/modules/theme_3nids/controllers/photo_3nids.php index d4ed2a71..3d3087ce 100755 --- a/themes/3nids_theme/modules/theme_3nids/controllers/photo_3nids.php +++ b/themes/3nids_theme/modules/theme_3nids/controllers/photo_3nids.php @@ -29,7 +29,7 @@ class Photo_3nids_Controller extends REST_Controller { $item = ORM::factory("item", $item_id); access::required("view", $item); - $view = new Theme_View("photo_3nids.html", "page"); + $view = new Theme_View("photo_3nids.html", "other", "page"); $view->item = $item; $photo_size = module::get_var("theme_3nids","photo_size"); if ($photo_size == "full"){ diff --git a/themes/night_wind/views/page.html.php b/themes/night_wind/views/page.html.php index f41dcd27..8ea0dc1c 100644 --- a/themes/night_wind/views/page.html.php +++ b/themes/night_wind/views/page.html.php @@ -33,7 +33,7 @@ " media="screen,print,projection" /> - page_type == 'album'): ?> + page_type == 'collection'): ?> @@ -61,10 +61,10 @@ script("ui.init.js") ?> head() they get combined */ ?> - page_type == "photo"): ?> + page_subtype == "photo"): ?> script("jquery.scrollTo.js") ?> script("gallery.show_full_size.js") ?> - page_type == "movie"): ?> + page_subtype == "movie"): ?> script("flowplayer.js") ?> @@ -122,7 +122,7 @@
- page_type != "login"): ?> + page_subtype != "login"): ?>
diff --git a/themes/night_wind/views/sidebar.html.php b/themes/night_wind/views/sidebar.html.php index cd50fc01..086d1359 100644 --- a/themes/night_wind/views/sidebar.html.php +++ b/themes/night_wind/views/sidebar.html.php @@ -1,13 +1,13 @@ sidebar_top() ?>
- + album_menu() ?> - + photo_menu() ?> - + movie_menu() ?> - + tag_menu() ?>